Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVC warning C4244 fixes #308

Merged
merged 6 commits into from Jan 12, 2022
Merged

MSVC warning C4244 fixes #308

merged 6 commits into from Jan 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 12, 2022

C4244(possible data loss) warnings in both the Compiler.cpp and BytecodeBuilder.cpp are fixed

rafa_br34 and others added 6 commits January 12, 2022 05:57
MSVC C4244 warning fix
77d9e8c 
Fix for the C4244(Possible data loss) warning for MSVC
Update Compiler.cpp
3c01448
@zeux
Update BytecodeBuilder.cpp
690a0ba 
Clean up casts
@zeux
Update Compiler.cpp
46578ca 
Remove redundant uint8_t(0) casts
@zeux
Update Compiler.cpp
c9afa0a 
Fix cid cast
@zeux
Update BytecodeBuilder.cpp
a342367 
Remove comment
zeux
zeux approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@zeux zeux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I did minor cleanup to make sure the style is more uniform.

@zeux zeux merged commit b7f78f4 into luau-lang:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zeux