Improve table stringifier when line breaks enabled #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks for the patch! Could you add a feature flag for this change? CONTRIBUTING.md has a quick outline of how to do this. |
Done! Apologies for the delay. Please let me know if this isn't the right way to add the FFlags. |
andyfriesen
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves
Luau::toString()on tables whenuseLineBreaksandindentis enabled, by adding linebreaks after the first brace, and before the last brace.Do note the increase in vertical lines in the large example below - I think it improves readability, but not sure if the increase is too big. (In VSCode the hover is scrollable so isn't really an issue, but I know the hover display is a bit primitive in Studio, so not sure what the impact will be)
Before:
After: