Add lua_tolightuserdata, optimized lua_topointer #496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds lua_tolightuserdata to the public API. Rationale:
First, it's faster than lua_touserdata when working purely with lightuserdata values. In our codebase we use lightuserdata for opaque 64-bit object handles (handles to objects managed by C++ code). With lua_touserlightdata we are seeing up to 8% performance improvement in Lua to C++ calls that use these handles. I believe this is a common use-case for lightuserdata.
Secondly, since the API already has lua_pushlightuserdata and lua_islightuserdata, it would make sense to have lua_tolightuserdata for completeness.
I also optimized lua_topointer a bit by reducing branching in userdata case.