Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Luau Benchmark Workflows #530

Merged
merged 116 commits into from
Jun 14, 2022
Merged

Conversation

AllanJeremy
Copy link
Contributor

Resolves #523
Resolves #524
Resolves #526
Resolves #525
Resolves #528

Summary

  • Added Luau Benchmark action. Runs luau benchmarks and outputs results in the benchmark result data repo.
  • Added the ability to use a different repo for storing benchmark results. GitHub pages for the results can be found here.
  • Added CacheGrind variation of the benchmark action

TODO: Test this upstream
Removed duplicate storage of benchmark output files
Using the one from the README now as opposed to the one from the build.yml
@zeux
Copy link
Collaborator

zeux commented Jun 8, 2022

Would it be feasible to merge CG & non-CG into a single .yml file? This will make it easier for us to adjust benchmarks in the future if it's all part of a single action we can eg run manually instead of having multiple.

@zeux
Copy link
Collaborator

zeux commented Jun 8, 2022

Btw https://luau-lang.github.io/benchmark-data/dev/bench/ doesn't seem to have cachegrind data charts, is that correct/expected?

@AllanJeremy
Copy link
Contributor Author

AllanJeremy commented Jun 9, 2022

Would it be feasible to merge CG & non-CG into a single .yml file? This will make it easier for us to adjust benchmarks in the future if it's all part of a single action we can eg run manually instead of having multiple.
Yes, done!

Btw https://luau-lang.github.io/benchmark-data/dev/bench/ doesn't seem to have cachegrind data charts, is that correct/expected?

Yes, this is expected. The other benchmark results have data because we ran a manual workflow on select releases for historical data while the cachegrind one only ran on PR (no historical data) therefore there is only one data point; which makes it look like it does not have charts.


Update: Discussed with Chris and removed all the data (test data). New data shall be generated on the Roblox org once this is merged in

@AllanJeremy AllanJeremy requested a review from zeux June 9, 2022 15:59
@zeux
Copy link
Collaborator

zeux commented Jun 9, 2022

The extra files in bench/ look like an accidental commit of intermediate files from a local run

@zeux zeux merged commit da01056 into luau-lang:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment