-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Luau Benchmark Workflows #530
Conversation
TODO: Test this upstream
Removed duplicate storage of benchmark output files
Using the one from the README now as opposed to the one from the build.yml
Would it be feasible to merge CG & non-CG into a single .yml file? This will make it easier for us to adjust benchmarks in the future if it's all part of a single action we can eg run manually instead of having multiple. |
Btw https://luau-lang.github.io/benchmark-data/dev/bench/ doesn't seem to have cachegrind data charts, is that correct/expected? |
Yes, this is expected. The other benchmark results have data because we ran a manual workflow on select releases for historical data while the cachegrind one only ran on PR (no historical data) therefore there is only one data point; which makes it look like it does not have charts. Update: Discussed with Chris and removed all the data (test data). New data shall be generated on the Roblox org once this is merged in |
The extra files in bench/ look like an accidental commit of intermediate files from a local run |
8a3cd2c
to
6fda242
Compare
Resolves #523
Resolves #524
Resolves #526
Resolves #525
Resolves #528
Summary