Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lanelet2 #468

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Add lanelet2 #468

merged 3 commits into from
Apr 20, 2024

Conversation

Tobias-Fischer
Copy link
Collaborator

No description provided.

@mantkiew
Copy link
Contributor

I'd like to comment about the error:

Could NOT find GeographicLib (missing: GeographicLib_LIBRARIES)

The conda-forge libgeographic package does not install Modules, only Config cmake files. Here's the explanation:

conda-forge/geographiclib-cpp-feedstock#12 (comment)

The problem with lanelet2 is that it gets libgeographic via crt_cmake_modules package, which is convenient but non-standard.

I've looked into it but my CMake skills are not sufficient. The idea is to change libgeographic lookup from as a module to as a config.

@Tobias-Fischer
Copy link
Collaborator Author

Do you think this simple trick is ok @traversaro ?

@traversaro
Copy link
Member

Do you think this simple trick is ok @traversaro ?

I am a bit afraid of this change, as it changes GeographicLib_LIBRARIES from pointing to the absolute path of the libraries, to use imported targets. The main problem of imported targets is that if code was developed assuming that GeographicLib_LIBRARIES are absolute paths, it may be possible that it calls target_link_libraries(libname PUBLIC ${GeographicLib_LIBRARIES}), and then install an exported target for libname, switching GeographicLib_LIBRARIES to use imported target would require find_package(GeographicLib CONFIG) to be called in libname CMake config files, introducing subtle bugs.

I think it may be safer to just fix the FindGeographicLib to use correct library names, see KIT-MRT/mrt_cmake_modules#34 .

@Tobias-Fischer Tobias-Fischer merged commit 2101d84 into main Apr 20, 2024
5 checks passed
@Tobias-Fischer Tobias-Fischer deleted the lanelet2 branch April 20, 2024 23:19
@Tobias-Fischer
Copy link
Collaborator Author

Great, thanks Silvio!

@mantkiew
Copy link
Contributor

Thanks a lot! I confirm I am able to install ros-noetic-lanelet2 in a new environment. There's still the other problem that it cannot be installed together with ros-noetic-dekstop due to ros-distro-mutex 0.5.* vs ros-distro-mutex 0.4.* required by noetic desktop. See #466 (comment)

But I can install both lanelet2 and velodyne-pointcloud together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants