-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gz_math_internal needs update to latest #17907
Comments
I don't think it's related to libsdformat. I took a closer look, and it appears all of
The first appears to be new. However, it is unclear why the last are present in Thus, I am punting to someone that knows more about what's going on there... |
The latest release is 6.13.0, but 7.0.0 has a prerelease and will have a stable release within the next few weeks. There are several changes to header files related to the name change from ignition -> gz for reasons outlined in the following post: In gz-math 7.0.0, the
It's kinda related because upgrading to libsdformat13 requires upgrading to gz-math7 (and gz-utils2). I have already done much of the bazel work required for this as part of my work on #17873 (see 915bfcf). If this is urgent, I could split out the portion of that work relevant to gz-math 6.13.0 and submit a pull request, but if it's not urgent, we could wait a few weeks for gz-math 7.0.0 to be released, at which point we could leapfrog over 6.13.0 directly to gz-math 7.0.0 along with libsdformat13 and gz-utils2. |
It's not urgent. Drake upgrades our externals on a monthly cadence so that we don't get too far behind upstream and so that we can obtain timely feedback about any regressions. Pushing that back by a few weeks or a month (especially when there is a Draft PR already under CI) is no burden. So, we can treat this as part of #17873 and so I'll reassign it accordingly. |
gz_math_internal needs to be updated to the latest release. It appears that a number of headers (and possible other files) have moved, making Bazel unhappy, and the changes are sufficiently non-trivial as to require sorting out on an individual file level (i.e. some things have changed and some apparently haven't, and someone needs to go through the files one at a time to identify which is which).
The text was updated successfully, but these errors were encountered: