Support capsule in parsing urdf #12254
Conversation
|
+@SeanCurtis-TRI for feature review please |
There was a problem hiding this comment.
+@sammy-tri for platform review, please.
Reviewed 3 of 3 files at r1.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee sammy-tri(platform) (waiting on @sammy-tri and @tehbelinda)
multibody/parsing/detail_urdf_geometry.cc, line 171 at r1 (raw file):
BTW It seems that radius here (and length below) need some extra punctuation.
Missing capsule attribute: radius
or
Missing capsule 'radius' attribute
Some such thing. As is, it doesn't quite seem to parse right.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @SeanCurtis-TRI)
multibody/parsing/detail_urdf_geometry.cc, line 171 at r1 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
BTW It seems that radius here (and length below) need some extra punctuation.
Missing capsule attribute: radius
or
Missing capsule 'radius' attribute
Some such thing. As is, it doesn't quite seem to parse right.
BTW the current spelling is consistent with the rest of the file. (which doesn't make it good).
tehbelinda
force-pushed
the
issue-10153-capsule-parsing-urdf
branch
from
b085507
to
83dbc15
Compare
|
multibody/parsing/detail_urdf_geometry.cc, line 171 at r1 (raw file): Previously, sammy-tri (Sam Creasey) wrote…
Added the : to this and the other similar ones |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),SeanCurtis-TRI(platform)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Relates to #10153
This change is