geometry: creates ellipsoid meshes. #12323
Conversation
There was a problem hiding this comment.
+@tehbelinda for feature review please.
Reviewable status: LGTM missing from assignee tehbelinda, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @tehbelinda)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @DamrongGuoy)
geometry/proximity/make_ellipsoid_mesh.h, line 44 at r1 (raw file):
`ellipsoid`'s major axis. @return The volume mesh for the given ellipsoid. @tparam T The Eigen-compatible scalar for representing the mesh vertex
minor - is there only supposed to be one space in between the @ tag and the following description? like after the @return?
DamrongGuoy
force-pushed
the
ellipsoid_mesh
branch
from
71ae8dc
to
8680495
Compare
There was a problem hiding this comment.
+@ggould-tri for platform review please.
Reviewable status: LGTM missing from assignee ggould-tri(platform) (waiting on @ggould-tri and @tehbelinda)
geometry/proximity/make_ellipsoid_mesh.h, line 44 at r1 (raw file):
Previously, tehbelinda (Bel) wrote…
minor - is there only supposed to be one space in between the @ tag and the following description? like after the @return?
Ok. I'm not sure. I see many files use different conventions. For this file, I changed to one space for both @return and @tparam now.
There was a problem hiding this comment.
Reviewable status: LGTM missing from assignee ggould-tri(platform) (waiting on @ggould-tri and @tehbelinda)
There was a problem hiding this comment.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all discussions resolved, LGTM from assignees ggould-tri(platform),tehbelinda
Create VolumeMesh and SurfaceMesh of a given Ellipsoid for hydroelastic contact models.
This change is