Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[geometry] Quarantine FCL's haphazard use of const in broadphase culling #12746

Merged

Conversation

SeanCurtis-TRI
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI commented Feb 18, 2020

Isolate the const_cast'ing required by FCL's interface.

resolves #12738


This change is Reviewable

Isolate the const_cast'ing required by FCL's interface.
Copy link
Contributor Author

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@ggould-tri for feature review (as your adroit eye caught the issue in the first place).

Reviewable status: LGTM missing from assignee ggould-tri(platform), needs at least two assigned reviewers (waiting on @ggould-tri)

Copy link
Contributor

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: This makes me so happy!

Reviewed 1 of 1 files at r1.
Reviewable status: needs at least two assigned reviewers

Copy link
Contributor Author

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And making you happy makes me happy. (And also benefits the code, but that's a lesser criteria.)

+@soonho-tri for platform review, please.

Reviewable status: LGTM missing from assignee soonho-tri(platform) (waiting on @soonho-tri)

Copy link
Member

@soonho-tri soonho-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 👍

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees ggould-tri(platform),soonho-tri(platform)

@soonho-tri soonho-tri merged commit 82386bc into RobotLocomotion:master Feb 19, 2020
@SeanCurtis-TRI SeanCurtis-TRI deleted the PR_quarantine_fcl_constness branch February 19, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[geometry] Interface with FCL has created explosion of const_cast
3 participants