Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate out the unit test for the degenerate case #14425

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Separate out the unit test for the degenerate case #14425

merged 1 commit into from
Dec 8, 2020

Conversation

ggould-tri
Copy link
Contributor

@ggould-tri ggould-tri commented Dec 8, 2020 •
edited by sherm1

This change is Reviewable

@ggould-tri
Copy link
Contributor Author

a discussion (no related file):
@drake-jenkins-bot linux-focal-clang-bazel-experimental-coverage please.

@ggould-tri
Separate out the unit test for the degenerate case
527070b 
 * This is a trivial disturbance to the test to correct
   a spurious kcov error; see
   SimonKagstrom/kcov#339
 * Closes RobotLocomotion#14424
@ggould-tri
Copy link
Contributor Author

a discussion (no related file):

Previously, ggould-tri wrote…

@drake-jenkins-bot linux-focal-clang-bazel-experimental-coverage please.

@drake-jenkins-bot linux-focal-clang-bazel-experimental-coverage please

@ggould-tri ggould-tri added the status: single reviewer ok https://drake.mit.edu/reviewable.html label Dec 8, 2020
ggould-tri
ggould-tri commented Dec 8, 2020
View reviewed changes
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@rpoyner-tri +(status: single reviewer ok) This should make your buildcop day happier.

Reviewable status: LGTM missing from assignee rpoyner-tri(platform) (waiting on @rpoyner-tri)

rpoyner-tri
rpoyner-tri reviewed Dec 8, 2020
View reviewed changes
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)

ggould-tri
ggould-tri commented Dec 8, 2020
View reviewed changes
Copy link
Contributor Author

@ggould-tri ggould-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform) (waiting on @ggould-tri)

a discussion (no related file):

Previously, ggould-tri wrote…

@drake-jenkins-bot linux-focal-clang-bazel-experimental-coverage please

FYI @rpoyner-tri I will probably be afk when this CI run completes; feel free to punch the merge button if it succeeds and don't wait for me.

@ggould-tri ggould-tri merged commit 0be3ddd into RobotLocomotion:master Dec 8, 2020
@DamrongGuoy DamrongGuoy mentioned this pull request Mar 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpoyner-tri rpoyner-tri rpoyner-tri left review comments

Assignees

@rpoyner-tri rpoyner-tri

Labels
status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious focal kcov failure on //math:gray_code_test
2 participants
@ggould-tri @rpoyner-tri