Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcl lifecycle api changes in post-foxy rolling distro #781

Closed
wayneparrott opened this issue Mar 25, 2021 · 1 comment · Fixed by #783
Closed

rcl lifecycle api changes in post-foxy rolling distro #781

wayneparrott opened this issue Mar 25, 2021 · 1 comment · Fixed by #783
Assignees

Comments

@wayneparrott
Copy link
Collaborator

wayneparrott commented Mar 25, 2021

CI builds are failing on all 3 platforms due to an api change in the rcl lifecycle api.

See:
ros2/rclcpp#1506
ros2/rcl#882

> rclnodejs@0.18.1 install /Users/distiller/RobotWebTools/rclnodejs
> node-gyp rebuild
...
  CXX(target) Release/obj.target/rclnodejs/src/rcl_bindings.o
../src/rcl_bindings.cpp:563:27: warning: overlapping comparisons always evaluate to false [-Wtautological-overlap-compare]
  if (type < RCL_ROS_TIME && type > RCL_STEADY_TIME) {
      ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
  
CXX(target) Release/obj.target/rclnodejs/src/rcl_handle.o
  CXX(target) Release/obj.target/rclnodejs/src/rcl_lifecycle_bindings.o
../src/rcl_lifecycle_bindings.cpp:79:28: error: no matching function for call to 'rcl_lifecycle_state_machine_init'
                           rcl_lifecycle_state_machine_init(
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../src/macros.hpp:30:49: note: expanded from macro 'THROW_ERROR_IF_NOT_EQUAL'
  CHECK_OP_AND_THROW_ERROR_IF_NOT_TRUE(!=, lhs, rhs, message)
                                                ^~~
../src/macros.hpp:22:16: note: expanded from macro 'CHECK_OP_AND_THROW_ERROR_IF_NOT_TRUE'
    if (lhs op rhs) {                                               \
               ^~~
/Users/distiller/ros2_install/ros2-osx/include/rcl_lifecycle/rcl_lifecycle.h:244:1: note: candidate function not viable: requires 9 arguments, but 10 were provided
rcl_lifecycle_state_machine_init(
^
../src/rcl_lifecycle_bindings.cpp:88:25: error: no matching function for call to 'rcl_lifecycle_state_machine_fini'
        rcl_ret_t ret = rcl_lifecycle_state_machine_fini(
                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/distiller/ros2_install/ros2-osx/include/rcl_lifecycle/rcl_lifecycle.h:278:1: note: candidate function not viable: requires 2 arguments, but 3 were provided
rcl_lifecycle_state_machine_fini(
^
2 errors generated.
@minggangw
Copy link
Member

Hi, @wayneparrott if you meet any difficulties, I'd like to help.

minggangw pushed a commit that referenced this issue Mar 29, 2021
fixes lifecycle statemachine init() and fini() api changes

fix #781
@minggangw minggangw added this to Done in v0.19.0 Release May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants