Add smoke test adapted from ROS 1 smoke test #585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the smoke test from develop on the ROS 2 branch.
.test
xml file.port:=0
to select an ephemeral port, and sets the port number in theactual_port
ROS param (similar to the Autobahn server implementation on develop). The test uses theGetParameters
service to retrieve the port number.I used various tricks to get
async
/await
working in the test. This was difficult because rclpy has its own executor that doesn't interoperate with other event loops (like twisted or asyncio). Since the test uses both ROS publishers/subscribers and a Twisted WebSocket client, both event loops are needed, so I ranrclpy.spin_until_future_complete
in a thread managed by Twisted. Mostly this worked nicely, but required care to usereactor.callFromThread
in certain places, and required some explicitexecutor.wake()
since the rclpy executor didn't automatically wake up when futures were resolved.