Fix test settings for rosbridge_library

[kenji-miyake]

Public Changes

None

Description

To keep the quality of libraries, it's important to re-enable tests as written in a TODO comment.
As a first step, I'd like to fix some errors to minimize the diff of the following PRs.

Also, I'll send some other PRs to fix each test.

Related: #644, #645, #646, #653

[kenji-miyake]

@jtbandes @amacneil @cclauss Hi, thank you for maintaining this great project! I saw the commit history and mentioned you.
Could you review this and related PRs, please? 🙏

[kenji-miyake]

I know some tests might require launch_testing like #585, but I think it's worth cleaning these up first.

[amacneil]

Agree with this direction, but could you make a PR (or update this one) that runs black on the whole codebase (and add to CI if possible)? That way we will be consistent everywhere.

It also looks like there might be other changes in this PR (cmake file?), it would be best if we do the formatting changes as one atomic unit separate from any other code changes.

[kenji-miyake]

could you make a PR (or update this one) that runs black on the whole codebase (and add to CI if possible)?

Yes, it's possible. I think pre-commit is a good way to do that as moveit teams do.
https://github.com/ros-planning/moveit2/blob/d184714751b347a2389cf1e8742b1be94eed63b8/.pre-commit-config.yaml#L35-L38

-> Added in #648

It also looks like there might be other changes in this PR (cmake file?), it would be best if we do the formatting changes as one atomic unit separate from any other code changes.

Yes, it's for fixing tests. I can split that into another PR.

[kenji-miyake]

@amacneil Thank you for merging #648. I rebased and changed the title of this PR!

[amacneil]

Thanks! Can you update the PR description too?

Tagging @jtbandes for a review

[kenji-miyake]

@amacneil Done! Removed format-related words and add a related PR.

[amacneil]

thanks!