Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose binary_encoder rosparam that was hidden in deep depth #281

Merged
merged 3 commits into from Jul 3, 2017

Conversation

@jihoonl
Copy link
Member

commented Jun 28, 2017

Review please.

Jihoon Lee added 2 commits Jun 28, 2017
Copy link
Contributor

left a comment

LGTM modulo small nit.

@@ -17,6 +17,7 @@
<arg name="services_glob" default="[*]" />
<arg name="params_glob" default="[*]" />
<arg name="bson_only_mode" default="false" />
<arg unless="$(arg bson_only_mode)" name="binary_encoder" default="default"/> <!-- b64, bson -->

This comment has been minimized.

Copy link
@adolfo-rt

adolfo-rt Jun 29, 2017

Contributor

Nit: Make the comment a bit more explicit. Something along the lines of :

<!-- Valid options are "default", "b64" and "bson". -->

This comment has been minimized.

Copy link
@jihoonl

jihoonl Jun 29, 2017

Author Member

Ok. Fixed.

@adolfo-rt adolfo-rt merged commit 2412fa2 into develop Jul 3, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@adolfo-rt adolfo-rt deleted the expose_b64 branch Jul 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.