Evaluate filter() generator before returning in get_param_names() #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #527.
This patch was needed when running rosapi under ROS Noetic which uses python3 due to the difference in in the return type of the
filter()
function between python2 and python3. In python2, a list is returned directly, but in python 3 a generator is returned which needs to be evaluated into a list to match the expected return type of theget_param_names()
function inparams.py
.Also tested using the ros-melodic docker container which uses python2 and it seems to work fine.
Please let me know if this is the wrong place to submit pull requests to, or if the python3/noetic migration work is being done elsewhere?