Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple indicator to examples showing the status of websocket connection #88

Merged
merged 1 commit into from
Jun 12, 2014

Conversation

T045T
Copy link
Contributor

@T045T T045T commented Jun 12, 2014

Related issue: #67

@rctoris
Copy link
Contributor

rctoris commented Jun 12, 2014

Looks okay to me. We should make sure http://wiki.ros.org/roslibjs#Tutorials matches the current examples though.

@T045T
Copy link
Contributor Author

T045T commented Jun 12, 2014

I'm not sure the error reporting code should be added to all the tutorials. Maybe a separate "Responding to errors" Tutorial would make this information easier to find?

@rctoris
Copy link
Contributor

rctoris commented Jun 12, 2014

Maybe, the idea was that the tutorials matched the example code. It's why the examples are relatively simple.

@T045T
Copy link
Contributor Author

T045T commented Jun 12, 2014

I just checked, and the code in the Tutorials doesn't contain the instructions that are present in the repo, since they're given in the tutorial text.

In the same vein, I think adding the <div> with the indicator texts to the tutorials isn't strictly necessary, but updating them to write more verbose output to the console makes sense.

@rctoris
Copy link
Contributor

rctoris commented Jun 12, 2014

👍 Sounds good to me

rctoris added a commit that referenced this pull request Jun 12, 2014
Add simple indicator to examples showing the status of websocket connection
@rctoris rctoris merged commit e37106c into RobotWebTools:develop Jun 12, 2014
@T045T
Copy link
Contributor Author

T045T commented Jun 12, 2014

The tutorials are all updated now :)

k-aguete pushed a commit to k-aguete/roslibjs that referenced this pull request Oct 21, 2022
Change linePrecision on raycaster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants