Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application Crashing on entering wrong pull request number #93

Open
ayush3160 opened this issue Apr 1, 2023 · 0 comments
Open

Application Crashing on entering wrong pull request number #93

ayush3160 opened this issue Apr 1, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ayush3160
Copy link
Contributor

Description:

Application is crashing when entering wrong pull request number to view the Pull request Details modal. If a user is entering wrong pull request number or invalid pull request in the /github Username/RepositoryName pulls pullNumber command then the Rocket.Chat server is crashing.

Steps to reproduce:

  1. Enter the command /github Username/RepositoryName pulls pullNumber with some wrong PR number.
  2. Notice application is crashing

Expected behavior:

A invalid-message modal should open in case of any wrong input.

Additional context

Rocket.Chat.-.1.April.2023.1.mp4
@ayush3160 ayush3160 added the bug Something isn't working label Apr 1, 2023
@ayush3160 ayush3160 mentioned this issue Apr 6, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ayush3160