Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] : Ability to toggle Password Visibility #369

Closed
2 tasks done
Akshun-01 opened this issue Dec 31, 2023 · 2 comments · Fixed by #382
Closed
2 tasks done

[Accessibility] : Ability to toggle Password Visibility #369

Akshun-01 opened this issue Dec 31, 2023 · 2 comments · Fixed by #382
Labels
enhancement New feature or request

Comments

@Akshun-01
Copy link
Contributor

Akshun-01 commented Dec 31, 2023

As an EmbeddedChat developer

I need to:
I think we should add the eye icon to toggle the encryption of password (which is very common in a lot of logging in interfaces.)
currently it looks like this
image

So That:
Adding the eye icon, will be helpful if anyone mistypes the password or want to double check rather than typing the password again from zero
Acceptance Criteria

  • Add the eye icon (make sure its responsive)
  • Add the toggling logic to it
@Akshun-01 Akshun-01 added the enhancement New feature or request label Dec 31, 2023
@Akshun-01
Copy link
Contributor Author

I would really like to work on this issue, if maintainers find it to be something that needs attention!

This was referenced Jan 1, 2024
@Akshun-01
Copy link
Contributor Author

Further Improvemnets that can be implemented on Login:

  • Error Modal to check for Incorrect or Empty fields
  • Using Enter key in addition to the Login Button

What are your thoughts on this ? @umangutkarsh @Yashraj7890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant