Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW][WIP] Add Crypto Wallet - MetaMask Connect Components Kit #92

Merged
merged 16 commits into from
May 20, 2022

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Mar 14, 2022

This PR introduces a new component to connect to MetasMask using methods available from the MetaMask API documentation page.
Here is a clip showing the demo of the component.

2022-03-14T07-38-33D0-14_AdobeCreativeCloudExpress.mp4

In the video, the "0" in the dark background is the balance while the hex string is the account identification number.

Thank you!

@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2022

This pull request introduces 5 alerts when merging 92d0657 into 50f7da2 - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@Dnouv
Copy link
Member Author

Dnouv commented Mar 14, 2022

In the latest commit, the style of the Chip illustrating the balance and the Account id is changed here is the new image,

image

Thank you!

@Sing-Li Sing-Li changed the title [NEW][WIP] Add MetaMask Connect Component [NEW][WIP] Add Crypto Wallet - MetaMask Connect Components Kit Mar 14, 2022
@Sing-Li
Copy link
Member

Sing-Li commented Mar 15, 2022

Excellent! Plese investigate and add:

  1. Brave Browser built-in wallet support, if it can expose the same set of APIs as MetaMask
  2. A few components displaying balances of the wallets (including erc-20 tokens)
  3. A component that renders visual NFTs - that can be eventually be added to our super profile

Please consider exposing APIs to support:

  1. token geted access
  2. in-chat token transactions (needs some new design)

@Dnouv
Copy link
Member Author

Dnouv commented Mar 15, 2022

Thank you for the review; I'll look into the support for the Brave wallet and will also expose the APIs currently, only two APIs are used, one to fetch the account and the other to fetch the balance. And will also investigate the other points mentioned above.
Thank you!

@lgtm-com
Copy link

lgtm-com bot commented Mar 16, 2022

This pull request introduces 3 alerts when merging cbb1942 into 50f7da2 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments

@Dnouv
Copy link
Member Author

Dnouv commented Mar 27, 2022

Update: Exposed the connect API
Added a new component NFTProfile to fetch a user's NFTs by connecting to the wallet.

NFT_Profile

Thank you!

@lgtm-com
Copy link

lgtm-com bot commented May 8, 2022

This pull request introduces 1 alert when merging 0ea549f into 1612542 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 9, 2022

This pull request introduces 1 alert when merging 07f8a86 into 1612542 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 9, 2022

This pull request introduces 1 alert when merging bf5053a into 1612542 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Sing-Li Sing-Li self-assigned this May 20, 2022
@Sing-Li Sing-Li merged commit 4481743 into RocketChat:master May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants