This repository has been archived by the owner on Jun 7, 2020. It is now read-only.
[FIX] 2.3.0 hotfix1 #1345
Merged
[FIX] 2.3.0 hotfix1 #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Http Logger to not log the auth token. Some dagger scopping changes
philipbrito
approved these changes
Jun 6, 2018
|
|
||
| import javax.inject.Qualifier | ||
|
|
||
| /** |
There was a problem hiding this comment.
If you can't now, we'll remove that later 👍
| import java.util.concurrent.TimeUnit | ||
|
|
||
| /** | ||
| * An OkHttp interceptor which logs request and response information. Can be applied as an |
There was a problem hiding this comment.
💯 copied from OkHttp logger... It is just a modified/kotlinfied version to remove the auth token from the logs
| try { | ||
| customTabsIntent.launchUrl(context, url) | ||
| } catch (ex: Exception) { | ||
| Timber.d(ex, "Unable to launch URL") |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for 2.3.0