Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Also send to channel" configurable #18347

Closed
piotrp opened this issue Jul 22, 2020 · 10 comments · Fixed by #26002
Closed

Make "Also send to channel" configurable #18347

piotrp opened this issue Jul 22, 2020 · 10 comments · Fixed by #26002

Comments

@piotrp
Copy link

piotrp commented Jul 22, 2020

Description:

Since #17416 it's difficult to follow conversations on team channels: it introduced an Also send to channel option which is always disabled and can't be permanently enabled. This should be configurable, preferably with per-channel (or just per-instance?) default.

Steps to reproduce:

  1. Click Reply in Thread
  2. Send message

Expected behavior:

Message is seen on team channel.

Actual behavior:

New message is difficult to see, the only thing that changes is reply counter near original message.

Server Setup Information:

  • Version of Rocket.Chat Server: 3.4.2
  • Operating System: Linux
  • Deployment Method: -
  • Number of Running Instances: -
  • DB Replicaset Oplog: -
  • NodeJS Version: -
  • MongoDB Version: -

Client Setup Information

  • Desktop App or Browser Version: Rocket.Chat.Electron 2.17.11
  • Operating System: Windows

Additional context

Default behavior changed with no way to get back to old one.

Relevant logs:

-

@gabriellsh
Copy link
Member

This already exists, on a per-user basis. Go to My Account > Preferences > Messages and enable Show thread messages in the main thread.

@danel1
Copy link

danel1 commented Jul 22, 2020

@gabriellsh Well thats one way to change it for an individual. But if the old default was false it's a pain to change for all users or even overwrite it. There really should be a way to change this globally for threads and not per user. Especially because it's a breaking change from 3.3.x to 3.4.x

@gabriellsh
Copy link
Member

@danel1 This issue was specific on this point Default behavior changed with no way to get back to old one.. That's why I closed it. But I agree you have a point that needs discussion. Could you open an issue regarding this? Thanks!

@danel1
Copy link

danel1 commented Jul 24, 2020

@gabriellsh why not just reopen this issue? :-)

@phlbrz
Copy link

phlbrz commented Jul 30, 2020

This already exists, on a per-user basis. Go to My Account > Preferences > Messages and enable Show thread messages in the main thread.

@gabriellsh @danel1

In my instance it is already enabled, but...

To get it work in 3.5.0 I had to disable, save, enable and save again, worked as expected.

Edit: I did in global configuration, as explained below:

I had to do in Administration -> Accounts -> Default User Preferences -> Show thread messages in the main thread

If enabled, then disable and save. Enable and save again.

@alexander-potemkin
Copy link

That's insane - don't forget to close preferences one pseudo-enabled + I can't walk for every (non-tech) user to disable it. Even when disabled, it still shows last messages in there. Threads logic seems to be completely broken on Rocket.Chat - guess it was rudimentary at the beginning, as the main functionality was 'Discussions' which is too big to start one.

@phlbrz
Copy link

phlbrz commented Dec 22, 2020

Yeah,

Today I upgraded my instances, from 3.2.2 to 3.9.3 and same problem...
I had to do this workaround #18347 (comment)

@SufiSR
Copy link

SufiSR commented Aug 11, 2021

Version 3.16.4

IMHO: I don't see a connection between the optional feature to disable/enable a view "Show thread messages in the main thread" and the checkbox "Also send to channel". I would think that the view shows me a thread including its messages or not.
The "Send to channel" Checkbox however should actually send the message to the main channel or not - which I wouldn't expect to have an impact on my view. It would always show if the user decided it must be in the channel.

Now, my challenge is the checkbox as well: For the first reply, the checkbox is always ticked. For every additional reply, it is not. So, right now, I need to tell users to always untick that checkbox for the first reply.

@Kyogre
Copy link

Kyogre commented Mar 26, 2022

as a workaround for now we use this script: #20695 (comment)

@dougfabris dougfabris reopened this Jun 24, 2022
@kodiakhq kodiakhq bot closed this as completed in #26002 Jun 27, 2022
kodiakhq bot pushed a commit that referenced this issue Jun 27, 2022
<!-- This is a pull request template, you do not need to uncomment or remove the comments, they won't show up in the PR text. -->

<!-- Your Pull Request name should start with one of the following tags
  [NEW] For new features
  [IMPROVE] For an improvement (performance or little improvements) in existing features
  [FIX] For bug fixes that affect the end-user
  [BREAK] For pull requests including breaking changes
  Chore: For small tasks
  Doc: For documentation
-->

<!-- Checklist!!! If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code. 
  - I have read the Contributing Guide - https://github.com/RocketChat/Rocket.Chat/blob/develop/.github/CONTRIBUTING.md#contributing-to-rocketchat doc
  - I have signed the CLA - https://cla-assistant.io/RocketChat/Rocket.Chat
  - Lint and unit tests pass locally with my changes
  - I have added tests that prove my fix is effective or that my feature works (if applicable)
  - I have added necessary documentation (if applicable)
  - Any dependent changes have been merged and published in downstream modules
-->

## Proposed changes (including videos or screenshots)
<!-- CHANGELOG -->
<!--
  Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
  If it fixes a bug or resolves a feature request, be sure to link to that issue below.
  This description will appear in the release notes if we accept the contribution.
-->
This PR removes the confusion between the `show message in main thread` and the function `also to send to channel`. In the past, we used the `show message in main thread` as a solution to help users to understand the thread feature, as this feature is now mature enough there's no reason to maintain this preference. 

Send the thread message to the main channel or just inside of the thread, should be a decision from the user where the function `also send to channel` appears. Because of that, and because of a bunch of requests and issues we received, we're introducing a new preference `also send thread to channel` where users will be able to decide the behavior of the checkbox. 

![image](https://user-images.githubusercontent.com/27704687/175655594-023c5907-adc8-4924-ba7d-467608d06fec.png)

Now there are three behavior options
- `Default`: when it unchecks after sending the first message
<img width='250px' height='350px' src='https://user-images.githubusercontent.com/27704687/175656500-34817639-7f13-4641-b4fa-9dd106e99443.gif' />

- `Always`: stay checked for all messages
<img width='250px' height='350px' src='https://user-images.githubusercontent.com/27704687/175657299-d88efaba-1c2b-4bb9-a23a-f9755dcec5ca.gif' />

- `Never`: stay unchecked for all messages
<img width='250px' height='350px' src='https://user-images.githubusercontent.com/27704687/175657544-3dcd0adc-05cf-4196-83a6-f6cc29a1de2b.gif' />

<!-- END CHANGELOG -->

## Issue(s)
<!-- Link the issues being closed by or related to this PR. For example, you can use #594 if this PR closes issue number 594 -->
Closes #20695
Closes #19167
Closes #18347

## Steps to test or reproduce
<!-- Mention how you would reproduce the bug if not mentioned on the issue page already. Also mention which screens are going to have the changes if applicable -->

## Further comments
<!-- If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->


Co-authored-by: Guilherme Gazzo <5263975+ggazzo@users.noreply.github.com>
@pcgeek86
Copy link

I can't find a way to enable the Also send thread message to channel behavior option on the Android mobile app. It seems you can only change it to Selected by default if you go into the Rocket Chat web interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants