-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC 6.4.8 after upgrade Ctrl + P doesnt work correctly #31112
Comments
I tested here and could reproduce the issue. Sometimes when searching the focus stays on the first item of the list of users, some other times it does not, and when pressing enter without a user being focused refreshes the page Questions? Help needed? Feature Requests?
|
Hello, @hugocostadev, sir I'm experiencing a similar issue. I'd like to address it and contribute to the solution. Thank you. |
Hey @Sumitwarrior7 the component is https://github.com/RocketChat/Rocket.Chat/blob/develop/apps/meteor/client/sidebar/search/SearchList.tsx Best of luck! |
@hugocostadev, I think this issue can be closed. |
is it merged or ready to merge? |
After upgrade to 6.6.5, it works correctly.. |
Description:
Yesterday I had to update our RC 3.15 which was running smoothly and correctly to the latest version 6.4.8 because of the apk and desktop app blocking warnings.
Since then, RC is a bit nicer but slower, reloading oft , code ``` now you most put it in another new line, ...
But the worst its when searching for channels or users with Ctrl+P works "sometimes".
When searching and starting with letters for example, I get several results and before automatically the first of the list when I hit enter entered that channel or user.
Now it does anything. Sometimes it does it correctly and many times it enters a channel or user that has nothing to do with the search.
Steps to reproduce:
Ctrl+P example + ENTER
Expected behavior:
Go to the first of the list while Im writing
Actual behavior:
ENTER
Server Setup Information:
Client Setup Information
Additional context
Relevant logs:
The text was updated successfully, but these errors were encountered: