Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 6.4.8 after upgrade Ctrl + P doesnt work correctly #31112

Closed
duven87 opened this issue Nov 30, 2023 · 6 comments
Closed

RC 6.4.8 after upgrade Ctrl + P doesnt work correctly #31112

duven87 opened this issue Nov 30, 2023 · 6 comments

Comments

@duven87
Copy link

duven87 commented Nov 30, 2023

Description:

Yesterday I had to update our RC 3.15 which was running smoothly and correctly to the latest version 6.4.8 because of the apk and desktop app blocking warnings.

Since then, RC is a bit nicer but slower, reloading oft , code ``` now you most put it in another new line, ...
But the worst its when searching for channels or users with Ctrl+P works "sometimes".

When searching and starting with letters for example, I get several results and before automatically the first of the list when I hit enter entered that channel or user.
Now it does anything. Sometimes it does it correctly and many times it enters a channel or user that has nothing to do with the search.

Steps to reproduce:

Ctrl+P example + ENTER

Expected behavior:

Go to the first of the list while Im writing

Actual behavior:

image
ENTER
image

Server Setup Information:

  • Version of Rocket.Chat Server: 6.4.8
  • Operating System: Debian 11
  • Deployment Method: tar
  • Number of Running Instances: 1
  • DB Replicaset Oplog: yes
  • NodeJS Version: v14.21.3
  • MongoDB Version: 5.0.23

Client Setup Information

  • Desktop App or Browser Version: Chromium Version 119.0.6045.159, app 3.9.10
  • Operating System: Mint 21.2 / Ubuntu 22

Additional context

Relevant logs:

@hugocostadev
Copy link
Contributor

I tested here and could reproduce the issue.

Sometimes when searching the focus stays on the first item of the list of users, some other times it does not, and when pressing enter without a user being focused refreshes the page


Questions? Help needed? Feature Requests?

@Sumitwarrior7
Copy link

Hello, @hugocostadev, sir

I'm experiencing a similar issue. I'd like to address it and contribute to the solution.
Could you tell me the relevant part of code related to this functionality?

Thank you.

@hugocostadev
Copy link
Contributor

@ChaudharyRaman
Copy link
Contributor

@hugocostadev, I think this issue can be closed.

@duven87
Copy link
Author

duven87 commented Jan 27, 2024

is it merged or ready to merge?

@duven87 duven87 closed this as completed Mar 23, 2024
@duven87
Copy link
Author

duven87 commented Mar 23, 2024

After upgrade to 6.6.5, it works correctly..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants