[FIX] "Idle Time Limit" using milliseconds instead of seconds #9824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
previously requested changes
Feb 21, 2018
| @@ -999,7 +999,7 @@ | |||
| "IssueLinks_LinkTemplate": "Template for issue links", | |||
| "IssueLinks_LinkTemplate_Description": "Template for issue links; %s will be replaced by the issue number.", | |||
| "It_works": "It works", | |||
| "Idle_Time_Limit": "Idle Time Limit", | |||
| "Idle_Time_Limit": "Idle Time Limit (Sec.)", | |||
There was a problem hiding this comment.
Can you add a Idle_Time_Limit_Description property and describe what it does?
|
@sampaiodiego Can you please add a milestone to this PR? |
geekgonecrazy
previously approved these changes
Mar 27, 2018
|
@kaiiiiiiiii can you rename your migration file to 109 and change from 108 to 109 inside the file also. Seems someone else added a migration for 108 and its already been merged |
geekgonecrazy
dismissed
their stale review
Need to rename before it can actually be merged
|
@geekgonecrazy done mate :) I've also merged the latest develop state into my branch. All tests passed now. |
|
@geekgonecrazy Changed migration version number again, as there had been a new merge conflict with another migration. Cheers |
graywolf336
changed the title
kaiiiiiiiii
deleted the
change_idle_time_limit_from_milliseconds_to_seconds
branch
MarcosSpessatto
added a commit
that referenced
this pull request
Apr 19, 2018
…-api-chat-postmessage-validations * commit 'a9fb4da5c847a456990a5d60369f0f52ff4a8bd8': (137 commits) Remove "secret" from REST endpoint /settings.oauth response [FIX] Directory sort and column sizes were wrong (#10403) [FIX] Add oauth services missing fields, and indicate whether the oauth service is customized (#10299) Show error message when email verification fails (#10446) Correct the column positions in the directory search for users (#10454) Fixed custom fields misalignment in registration form (#10463) [FIX] Unique identifier file not really being unique (#10341) [OTHER] More Listeners for Apps & Utilize Promises inside Apps (#10335) [FIX] Empty panel after changing a user's username (#10404) [FIX] Russian translation of "False" (#10418) [FIX] Links being embedded inside of blockquotes (#10496) [FIX] The 'channel.messages' REST API Endpoint error (#10485) [OTHER] Develop sync (#10487) [FIX] Button on user info contextual bar scrolling with the content (#10358) [FIX] "Idle Time Limit" using milliseconds instead of seconds (#9824) [NEW] Body of the payload on an incoming webhook is included on the request object (#10259) [FIX] Missing i18n translation key for "Unread" (#10387) [FIX] Owner unable to delete channel or group from APIs (#9729) [NEW] REST endpoint to recover forgotten password (#10371) Add REST endpoint chat.reportMessage, to report a message (#10354) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've closed my other PR (#9675) in favor of this one, because I really messed up with almost everything.
This time I forked the latest develop branch and requested to merge the PR back into develop. I'm sorry for any inconvenience, but I'm pretty new to git group projects :)
Summary old PR
For users it's pretty unhandy to fill out the "Idle Time Limit" in milliseconds. As discussed with @geekgonecrazy and @JSzaszvari it would be more practical to set this value in seconds. @sampaiodiego targets version 0.63.0 for this fix.