Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Leave room wasn't working as expected #10851

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
5 participants
@ggazzo
Copy link
Member

ggazzo commented May 22, 2018

(textarea is visible after message)
Closes #5358
Closes #7271
before
image

after
image

@ggazzo ggazzo added this to the 0.66.0 milestone May 22, 2018

@ggazzo ggazzo added this to Desireable in June/2018 via automation May 22, 2018

@engelgabriel engelgabriel temporarily deployed to rocket-chat-pr-10851 May 22, 2018 Inactive

@ggazzo ggazzo moved this from Desireable to Review/QA in June/2018 May 22, 2018

@ggazzo ggazzo added the subj: ui/ux label May 22, 2018

@engelgabriel

This comment has been minimized.

Copy link
Member

engelgabriel commented May 22, 2018

@ggazzo why did you remove the client side method?

@karlprieb karlprieb changed the title [FIX] leave room bug [WIP] [FIX] leave room bug May 22, 2018

@ggazzo

This comment has been minimized.

Copy link
Member Author

ggazzo commented May 23, 2018

because that method is the problem (:, as we don't use a subscription (we use a stream) to keep the room data, client + server methods doesnt work as expected

@ggazzo ggazzo force-pushed the leave-room-bug branch from 5bfa298 to 68e51b5 May 23, 2018

@ggazzo ggazzo changed the title [WIP] [FIX] leave room bug [FIX] leave room bug May 23, 2018

@ggazzo ggazzo moved this from Review/QA to Ready to merge in June/2018 May 25, 2018

@ggazzo ggazzo referenced this pull request May 25, 2018

Closed

Leaving owner #7271

@mikaelmello

This comment has been minimized.

Copy link
Contributor

mikaelmello commented May 28, 2018

@ggazzo , about the client method, is it possible that something similar could be happening with #10723?

@rodrigok rodrigok modified the milestones: 0.66.0, 0.65.1 May 29, 2018

@rodrigok rodrigok changed the title [FIX] leave room bug [FIX] Leave room wasn't working as expected May 29, 2018

@rodrigok rodrigok merged commit 9668c6d into develop May 29, 2018

4 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: test-with-oplog Your tests passed on CircleCI!
Details
ci/circleci: test-without-oplog Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details

June/2018 automation moved this from Ready to merge to Closed May 29, 2018

@rodrigok rodrigok deleted the leave-room-bug branch May 29, 2018

sampaiodiego added a commit that referenced this pull request May 30, 2018

Merge pull request #10851 from RocketChat/leave-room-bug
[FIX] Leave room wasn't working as expected

engelgabriel added a commit that referenced this pull request Jun 4, 2018

Merge branch 'master' into sync-master
* master:
  Bump version to 0.65.1
  Merge pull request #10940 from RocketChat/fix-livechat-not-loading
  Merge pull request #10934 from RocketChat/prevent-sending-exceptions-to-channel-before-startup
  Merge pull request #10928 from RocketChat/fix-email-notification-link
  Merge pull request #10904 from RocketChat/lazyload-fix-regression
  Merge pull request #10851 from RocketChat/leave-room-bug
  fix search shortcut text
  Display vertical scrollbar on demand

# Conflicts:
#	.docker/Dockerfile
#	.docker/Dockerfile.rhel
#	.sandstorm/sandstorm-pkgdef.capnp
#	.travis/snap.sh
#	HISTORY.md
#	package.json
#	packages/rocketchat-lib/rocketchat.info

@rodrigok rodrigok referenced this pull request Jun 28, 2018

Merged

Release 0.66.0 #11278

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.