[FIX] Leave room wasn't working as expected #10851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ggazzo why did you remove the client side method? |
|
because that method is the problem (:, as we don't use a subscription (we use a stream) to keep the room data, client + server methods doesnt work as expected |
karlprieb
approved these changes
May 23, 2018
Closed
rodrigok
changed the title
sampaiodiego
pushed a commit
that referenced
this pull request
May 30, 2018
[FIX] Leave room wasn't working as expected
engelgabriel
added a commit
that referenced
this pull request
Jun 4, 2018
* master: Bump version to 0.65.1 Merge pull request #10940 from RocketChat/fix-livechat-not-loading Merge pull request #10934 from RocketChat/prevent-sending-exceptions-to-channel-before-startup Merge pull request #10928 from RocketChat/fix-email-notification-link Merge pull request #10904 from RocketChat/lazyload-fix-regression Merge pull request #10851 from RocketChat/leave-room-bug fix search shortcut text Display vertical scrollbar on demand # Conflicts: # .docker/Dockerfile # .docker/Dockerfile.rhel # .sandstorm/sandstorm-pkgdef.capnp # .travis/snap.sh # HISTORY.md # package.json # packages/rocketchat-lib/rocketchat.info
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(textarea is visible after message)
Closes #5358
Closes #7271
before
after
