Chore: Update Meteor to 2.5.3 #24075

sampaiodiego · 2021-12-31T14:52:36Z

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

~~This is a very early draft. Things still missing:~~

~~I have a local copy of all those packages updated, it is just a matter of forking and publishing.~~

~~The other issues are real work that needs to be done.~~

What needs to be tested

Some parts of the system had to be re-written, so it would be good to have a focus on tests:

Apps using the HTTP bridge
App management (install from zip, install from url, update, etc)
Integrations:
- Outgoing webhook requests
- Incoming/outgoing webhook with custom scripts using HTTP calls
Update avatar from URL
File upload coming from SMS/MMS (omnichannel)
Logout from other clients
Oembed (URL previews on messages)
Services - both using micro services with an EE license and the execution of internal services on CE
The email sending during tests had to be overwritten to show only a console.log
Every outgoing request that should not validate the HTTP certificate (per "Allow Invalid Self-Signed Certs" setting)
LinkedIn Oauth flow

It apparently is compatiable with IE11 again meteor/meteor#11772

sampaiodiego · 2021-12-31T14:56:44Z

so looks like the async hooks issue was fixed on recent node versions nodejs/node#34556 (v15+)
but since we need to stick with v14, I'm not sure how to deal with it

github-actions

You have added 6 .js files, please convert to ts(x).
packages/accounts-linkedin/linkedin.js
packages/accounts-linkedin/notice.js
packages/accounts-linkedin/package.js
packages/linkedin-oauth/linkedin-client.js
packages/linkedin-oauth/linkedin-server.js
packages/linkedin-oauth/package.js

sampaiodiego · 2022-01-03T12:47:11Z

with all package dependencies updated, everyone is able to run the code now.

js files removed

lgtm-com · 2022-01-05T18:11:36Z

This pull request introduces 7 alerts when merging ad5f566 into bf6878e - view on LGTM.com

new alerts:

4 for Syntax error
3 for Comparison between inconvertible types

lgtm-com · 2022-01-10T18:41:12Z

This pull request introduces 1 alert and fixes 2 when merging b665425 into 0e755f2 - view on LGTM.com

new alerts:

1 for Disabling certificate validation

fixed alerts:

2 for Useless conditional

debdutdeb · 2022-01-10T18:54:30Z

@RocketChat/documentation-team fyi - parts of our documentation might need update. Would be good to have them ready before this gets merged, especially with the gsoc students coming in.

Let me know if I can help in any way.

debdutdeb · 2022-01-10T19:02:55Z

cc @Rodriq (since you weren't in the gh team when i mentioned by that)

lgtm-com · 2022-01-10T22:31:46Z

This pull request introduces 1 alert and fixes 2 when merging 1df2cb4 into 50d55d7 - view on LGTM.com

new alerts:

1 for Disabling certificate validation

fixed alerts:

2 for Useless conditional

alansikora

Great job

tassoevan · 2022-01-11T19:11:51Z

package.json

@@ -230,7 +230,7 @@
 		"express": "^4.17.1",
 		"express-rate-limit": "^5.2.6",
 		"fflate": "^0.7.1",
-		"fibers": "4.0.3",
+		"fibers": "^5.0.0",


Is this going to break CentOS 7 support?

I hope not. I can make sure and test it though

lgtm-com · 2022-01-12T12:02:57Z

This pull request introduces 1 alert and fixes 2 when merging 1544a5e into a06e811 - view on LGTM.com

new alerts:

1 for Disabling certificate validation

fixed alerts:

2 for Useless conditional

lgtm-com · 2022-01-12T13:11:24Z

This pull request introduces 1 alert and fixes 2 when merging af58958 into a06e811 - view on LGTM.com

new alerts:

1 for Disabling certificate validation

fixed alerts:

2 for Useless conditional

lgtm-com · 2022-01-13T18:57:35Z

This pull request introduces 1 alert and fixes 2 when merging 4644f91 into f37c2f4 - view on LGTM.com

new alerts:

1 for Disabling certificate validation

fixed alerts:

2 for Useless conditional

debdutdeb · 2022-01-14T12:55:10Z

.docker-mongo/Dockerfile

@@ -36,12 +36,12 @@ RUN aptMark="$(apt-mark showmanual)" \
    && apt-mark auto '.*' > /dev/null \
    && apt-mark manual $aptMark > /dev/null \
    && find /usr/local -type f -executable -exec ldd '{}' ';' \


Suggested change

&& find /usr/local -type f -executable -exec ldd '{}' ';' \

&& find /usr/local -type f -perm /111 -exec ldd '{}' ';' \

-executable doesn't exactly detect if a file is executable or not, since it uses the access syscall. It can potentially return all files (and dirs if no -type f) for a given directory. Since we are updating a lot of stuff in this pr already, let's also change it from this point.

I have not tested it yet, but this change shouldn't affect the image in any way.

Let me know if I'm misreading the purpose of this line 🙈

"on behalf of" definitely not right 😬

I have to say I don't know what that does 😅 it was copied from node's Dockerfile 🤷

https://github.com/nodejs/docker-node/blob/66b46292a6e5dd5856b1d5204dc51547c80eb17a/14/buster-slim/Dockerfile#L45

Looks to me like it's making sure all npm/node dependencies are not accidentally removed when removing some other package with a similar dependency, thus not reducing/eliminating child image issues.

Also, looking at the Dockerfile, I'm not sure we even need those lines to be part of our image, do you remember why those were added initially? 🤔

this image specifically is not intended for production, we call is as "preview" since it has mongo installed and can be used to have a "preview" of a rocket.chat version.

we use the same technique on the production one though.. the ideia is to install some packages just to run the npm install and then clean it up..

Hmm, looks like I commented on the wrong file, but these are part of our production one as well .docker/Dockerfile.

this isn't a big deal 🙈 maybe slightly more time spent on 'building', nothing else.

lgtm-com · 2022-01-14T18:31:06Z

This pull request introduces 1 alert and fixes 2 when merging 6a46e57 into 1441feb - view on LGTM.com

new alerts:

1 for Disabling certificate validation

fixed alerts:

2 for Useless conditional

debdutdeb · 2022-01-14T18:34:42Z

Since it is not part of the diff, the Dockerfile contains the MONGO_(OPLOG_)?URL variables, continuing the alpine image discussion, maybe we should consider not keeping them?

If we need them to be part of the Dockerfile for some external tool parsing, we can just mark them without putting any values

env MONGO_URL ''
env MONGO_OPLOG_URL ''

Ex.

Dockerfile

from scratch

env MONGO_URL ''

[debdut@Venn dd]$ docker inspect -f '{{ .Config.Env}}' 31208319d32a
[PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin MONGO_URL=]

AFAIK the connection string also has to have the replicaset information a part as well now, which means another assumption by the image.

…ove/setup-wizard * 'develop' of github.com:RocketChat/Rocket.Chat: (176 commits) [IMPROVE] Admin page header buttons consistency (#24168) i18n: Language update from LingoHub 🤖 on 2022-01-17Z (#24193) [FIX] Integration section crashing opening in My Account (#24068) [IMPROVE] Rewrite roomNotFound to React Component (#24044) Regression: Enable custom emoji on admin custom status page (#24186) Chore: Update Meteor to 2.5.3 (#24075) [NEW] Apple Login (#24060) Chore: Update Apps-Engine to 1.29.2 (#24171) feat: enabling emoji on custom status (#24170) [FIX] App Framework Enable hanging indefinitely (#24158) [FIX] CSV Importer failing to import users (#24090) Fix Engagement Dashboard API requests (#24142) Language update from LingoHub 🤖 (#24127) Chore: Migrate useOutsideClick to fuselage-hooks (#24133) Revert "Use fibers to store context" Use fibers to store context Chore: Include REG_TOKEN in docker-compose (#24123) [FIX] Custom Emoji Image preview #24117 [IMPROVE] Added a Reset Button in the Account Profile Page (#24078) Revert: "[IMPROVE] Throw 404 error in invalid endpoints" (#24118) ...

sampaiodiego added 6 commits December 31, 2021 11:02

Meteor update

1d33164

Remove overwride of react-fast-refresh

4f5c16b

It apparently is compatiable with IE11 again meteor/meteor#11772

Fix LivechatBusinessHoursRaw model

f722c52

Need fix: stop using HTTPInternals

3456005

Need fix: async_hooks error

6958372

Fix some lint issues

4365d5e

sampaiodiego added 4 commits December 31, 2021 12:07

Make eslint happy before rewrite

7296689

Copy code from LinkedIn auth packages

68efae6

Use forked restivus

54982ef

Merge remote-tracking branch 'origin/develop' into update-meteor-2.5.2

5b467ef

github-actions bot previously requested changes Jan 3, 2022

View reviewed changes

Ignore JS files in copied packages

b30ba91

Update Node version

6eb02f0

sampaiodiego mentioned this pull request Jan 3, 2022

Add: Alpine image as option for build #12548

Merged

1 task

sampaiodiego added 10 commits January 3, 2022 18:49

Let's try debian bullseye

b80f8ba

Skip failing test and add some TODOs

c537a64

skip another test

34570ff

Fix preview Dockerfile

42d4299

Skip whole oembed

8cebcfd

Add TODOs regarding npmRequestOptions

32582d4

Fix lint

910a5fc

Skip app's tests

382c91b

Fix Dockerfile syntax

99bd5f3

Merge branch 'develop' into update-meteor-2.5.2

cfa819d

RocketChat deleted a comment from lgtm-com bot Jan 5, 2022

Use meteor/fetch on apps routes

ad5f566

sampaiodiego added 2 commits January 10, 2022 19:19

Fix new integration log no returning id

226b168

Fix integration response script

1df2cb4

rodrigok previously approved these changes Jan 11, 2022

View reviewed changes

alansikora previously approved these changes Jan 11, 2022

View reviewed changes

tassoevan reviewed Jan 11, 2022

View reviewed changes

Merge branch 'develop' into update-meteor-2.5.2

1544a5e

sampaiodiego added 2 commits January 12, 2022 09:10

Fix Linkedin OAuth

07344e9

Fix non-downloadable SMS files

af58958

sampaiodiego dismissed stale reviews from alansikora and rodrigok via af58958 January 12, 2022 12:56

sampaiodiego added 2 commits January 13, 2022 15:46

Add Node and Mongo versions to release update request

e426409

Merge branch 'develop' into update-meteor-2.5.2

4644f91

debdutdeb reviewed Jan 14, 2022

View reviewed changes

ggazzo approved these changes Jan 14, 2022

View reviewed changes

Merge branch 'develop' into update-meteor-2.5.2

6a46e57

sampaiodiego changed the title ~~Chore: Update Meteor to 2.5.2~~ Chore: Update Meteor to 2.5.3 Jan 14, 2022

sampaiodiego merged commit 96c5555 into develop Jan 14, 2022

sampaiodiego deleted the update-meteor-2.5.2 branch January 14, 2022 21:01

sampaiodiego mentioned this pull request Jan 29, 2022

Release 4.4.0 #24342

Merged

tassoevan mentioned this pull request Apr 4, 2022

RocketChat 4.3.0 Segmentation Fault #24080

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore: Update Meteor to 2.5.3 #24075

Chore: Update Meteor to 2.5.3 #24075

sampaiodiego commented Dec 31, 2021 •

edited

Loading

sampaiodiego commented Dec 31, 2021

github-actions bot left a comment

sampaiodiego commented Jan 3, 2022

lgtm-com bot commented Jan 5, 2022

lgtm-com bot commented Jan 10, 2022

debdutdeb commented Jan 10, 2022

debdutdeb commented Jan 10, 2022

lgtm-com bot commented Jan 10, 2022

alansikora left a comment

tassoevan Jan 11, 2022

sampaiodiego Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 13, 2022

debdutdeb Jan 14, 2022

debdutdeb Jan 14, 2022

sampaiodiego Jan 14, 2022 •

edited

Loading

debdutdeb Jan 14, 2022

sampaiodiego Jan 14, 2022 •

edited

Loading

debdutdeb Jan 14, 2022

lgtm-com bot commented Jan 14, 2022

debdutdeb commented Jan 14, 2022 •

edited

Loading

	&& find /usr/local -type f -executable -exec ldd '{}' ';' \
	&& find /usr/local -type f -perm /111 -exec ldd '{}' ';' \

Chore: Update Meteor to 2.5.3 #24075

Chore: Update Meteor to 2.5.3 #24075

Conversation

sampaiodiego commented Dec 31, 2021 • edited Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

What needs to be tested

sampaiodiego commented Dec 31, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

sampaiodiego commented Jan 3, 2022

lgtm-com bot commented Jan 5, 2022

lgtm-com bot commented Jan 10, 2022

debdutdeb commented Jan 10, 2022

debdutdeb commented Jan 10, 2022

lgtm-com bot commented Jan 10, 2022

alansikora left a comment

Choose a reason for hiding this comment

tassoevan Jan 11, 2022

Choose a reason for hiding this comment

sampaiodiego Jan 12, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 13, 2022

debdutdeb Jan 14, 2022

Choose a reason for hiding this comment

debdutdeb Jan 14, 2022

Choose a reason for hiding this comment

sampaiodiego Jan 14, 2022 • edited Loading

Choose a reason for hiding this comment

debdutdeb Jan 14, 2022

Choose a reason for hiding this comment

sampaiodiego Jan 14, 2022 • edited Loading

Choose a reason for hiding this comment

debdutdeb Jan 14, 2022

Choose a reason for hiding this comment

lgtm-com bot commented Jan 14, 2022

debdutdeb commented Jan 14, 2022 • edited Loading

sampaiodiego commented Dec 31, 2021 •

edited

Loading

sampaiodiego Jan 14, 2022 •

edited

Loading

sampaiodiego Jan 14, 2022 •

edited

Loading

debdutdeb commented Jan 14, 2022 •

edited

Loading