[FIX] Custom Emoji Image preview #24117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless I'm doing some fundamental mistake, |
sidmohanty11
force-pushed
the
custom-emoji-preview-img
branch
from
041caf3
to
df76d75
Compare
|
Done! @tassoevan |
dougfabris
approved these changes
Jan 7, 2022
gabriellsh
added a commit
that referenced
this pull request
Jan 17, 2022
…ove/setup-wizard * 'develop' of github.com:RocketChat/Rocket.Chat: (176 commits) [IMPROVE] Admin page header buttons consistency (#24168) i18n: Language update from LingoHub 🤖 on 2022-01-17Z (#24193) [FIX] Integration section crashing opening in My Account (#24068) [IMPROVE] Rewrite roomNotFound to React Component (#24044) Regression: Enable custom emoji on admin custom status page (#24186) Chore: Update Meteor to 2.5.3 (#24075) [NEW] Apple Login (#24060) Chore: Update Apps-Engine to 1.29.2 (#24171) feat: enabling emoji on custom status (#24170) [FIX] App Framework Enable hanging indefinitely (#24158) [FIX] CSV Importer failing to import users (#24090) Fix Engagement Dashboard API requests (#24142) Language update from LingoHub 🤖 (#24127) Chore: Migrate useOutsideClick to fuselage-hooks (#24133) Revert "Use fibers to store context" Use fibers to store context Chore: Include REG_TOKEN in docker-compose (#24123) [FIX] Custom Emoji Image preview #24117 [IMPROVE] Added a Reset Button in the Account Profile Page (#24078) Revert: "[IMPROVE] Throw 404 error in invalid endpoints" (#24118) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using URL.createObjectURL() it produces a blob url which is not present in cors content-security-policy header so, its showing that error.
By making a data url, the image preview works fine.
Proposed changes (including videos or screenshots)
Before,
After,
also if any error, (for example - if we upload a video mp4 file)
Issue(s)
Closes #24082
Steps to test or reproduce
Further comments