Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert email inbox feature to TypeScript #25298

Merged
merged 18 commits into from
May 10, 2022

Conversation

ujorgeleite
Copy link
Contributor

@ujorgeleite ujorgeleite commented Apr 25, 2022

chore: add endpoint types for email-inboxes
chore: add migration for some e-mail-inboxes files

Wasn't migrated all file folders on this pr, but we can merge, and after we will migrate in the next engineering day.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ujorgeleite ujorgeleite requested a review from ggazzo April 25, 2022 12:39
@ujorgeleite ujorgeleite changed the title Chore/endpoint email inbox chore: [EngDay] endpoint email inbox Apr 25, 2022
@ujorgeleite ujorgeleite changed the title chore: [EngDay] endpoint email inbox Chore[EngDay] : convert emailInbox folder to typescript Apr 25, 2022
@ujorgeleite ujorgeleite changed the title Chore[EngDay] : convert emailInbox folder to typescript Chore : convert emailInbox folder to typescript Apr 25, 2022
@ujorgeleite ujorgeleite changed the title Chore : convert emailInbox folder to typescript Chore: convert emailInbox folder to typescript Apr 25, 2022
@ujorgeleite ujorgeleite marked this pull request as ready for review May 2, 2022 15:38
@ujorgeleite ujorgeleite requested a review from a team as a code owner May 2, 2022 15:38
apps/meteor/app/api/server/v1/email-inbox.ts Outdated Show resolved Hide resolved
apps/meteor/app/api/server/v1/email-inbox.ts Outdated Show resolved Hide resolved
@ujorgeleite ujorgeleite requested a review from a team as a code owner May 5, 2022 17:52
@tassoevan tassoevan changed the title Chore: convert emailInbox folder to typescript Chore: Convert email inbox feature to TypeScript May 10, 2022
@tassoevan tassoevan merged commit ee1d146 into develop May 10, 2022
@tassoevan tassoevan deleted the chore/endpoint-email-inbox branch May 10, 2022 22:55
souzaramon pushed a commit that referenced this pull request May 11, 2022
* chore: email-inbox rest types

* Fix email inbox types

* Email inbox endpoints to TS

* Fix email-inbox params

* Chore: Lib emailInbox to ts

* chore: migrate to typescript

* chore: fix lint

* chore: fix table sort

* Fix endpoint types

* Chore: methods to insert and update was splitted

* Removed the wrong validation

* Back to default types for sort and query

* Purge build files before compile

* Require some fields of `IEmailInbox`

* Fix weird destructuring

Co-authored-by: albuquerquefabio <albuquerquefabio@icloud.com>
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
gabriellsh added a commit that referenced this pull request May 12, 2022
…lists

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Move markdown message parser to a `callback` (#25413)
  [FIX] Settings listeners not receiving overwritten values from env vars (#25448)
  Chore: Move ddp-streamer micro service to its own sub-repo (#25246)
  [NEW] Use setting to determine if initial general channel is needed (#25441)
  [IMPROVE] New admin settings Page (#25439)
  [FIX] Failure to update Integration History index (#25473)
  Chore: Rewrite 2fa to typescript (#25285)
  Chore: solve yarn issues from env var (#25468)
  Chore: REST query and body params validation (#25446)
  Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) (#25416)
  Chore: Convert email inbox feature to TypeScript (#25298)
gabriellsh added a commit that referenced this pull request May 16, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Migrate NotFoundPage to TS (#25509)
  [FIX] Unable to see channel member list by authorized channel roles (#25412)
  Regression: Fix services-image-build-check (#25519)
  Chore: Migrate spotify to ts (#25507)
  [Chore] Reorder unreleased migrations (#25508)
  [FIX] Spotlight results showing usernames instead of real names (#25471)
  [FIX] LDAP sync removing users from channels when multiple groups are mapped to it (#25434)
  Chore: Move markdown message parser to a `callback` (#25413)
  [FIX] Settings listeners not receiving overwritten values from env vars (#25448)
  Chore: Move ddp-streamer micro service to its own sub-repo (#25246)
  [NEW] Use setting to determine if initial general channel is needed (#25441)
  [IMPROVE] New admin settings Page (#25439)
  [FIX] Failure to update Integration History index (#25473)
  Chore: Rewrite 2fa to typescript (#25285)
  Chore: solve yarn issues from env var (#25468)
  Chore: REST query and body params validation (#25446)
  Chore: Tests with Playwright (task: ROC-66, Intermittent resolution in tests) (#25416)
  Chore: Convert email inbox feature to TypeScript (#25298)
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants