Chore: convert invites, misc and subscriptions to TS and create definitions #25350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggazzo
force-pushed
the
chore/convert-ts-and-create-endpoints
branch
from
e7042b4
to
89017c8
Compare
ggazzo
requested changes
May 24, 2022
ggazzo
force-pushed
the
chore/convert-ts-and-create-endpoints
branch
from
bfa1e86
to
20487b1
Compare
…nd-create-endpoints
ggazzo
force-pushed
the
chore/convert-ts-and-create-endpoints
branch
from
20487b1
to
bc0bf0c
Compare
|
This pull request introduces 1 alert when merging c65b728 into 81304fe - view on LGTM.com new alerts:
|
ggazzo
force-pushed
the
chore/convert-ts-and-create-endpoints
branch
from
313d05e
to
6ce41de
Compare
ggazzo
force-pushed
the
chore/convert-ts-and-create-endpoints
branch
from
6ce41de
to
bb350be
Compare
ggazzo
force-pushed
the
chore/convert-ts-and-create-endpoints
branch
from
8f69518
to
8e94144
Compare
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
pierre-lehnen-rc
previously approved these changes
Jun 7, 2022
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
ggazzo
approved these changes
Jun 7, 2022
gabriellsh
added a commit
that referenced
this pull request
Jun 8, 2022
…homepage * 'develop' of github.com:RocketChat/Rocket.Chat: Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
gabriellsh
added a commit
that referenced
this pull request
Jun 8, 2022
… feat/custom-homepage-setting * 'new/homepage' of github.com:RocketChat/Rocket.Chat: Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
gabriellsh
added a commit
that referenced
this pull request
Jun 9, 2022
… feat/new-header * 'new/homepage' of github.com:RocketChat/Rocket.Chat: [NEW] Add Custom homepage Content Setting (#25777) Chore: Fix CI (#25797) [FIX] Fix prom-client new promise usage (#25781) [FIX] Discussion alphabetical ordering (#25788) Update .kodiak.toml Update .kodiak.toml Chore: Testing Kodiak feature (#25794) [FIX] Broken Omnichannel>Agents page (#25731) [FIX] Sanitize styles in message (#25744) chore: Convert to TS RoomAutoComplete (#25536) Chore: API test on method GET with params as a number. (#25769) Chore: convert invites, misc and subscriptions to TS and create definitions (#25350) Chore: Remove .snapcraft Chore: Remove toastr package (#25787) [BREAK] Remove Blockstack authentication (#25649) [FIX] getUserMentionsByChannel method room permission (#25748) [NEW] Fuselage ToastBar (#25583)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Converted
apps/meteor/app/api/server/v1/invites.js,misc.jsandsubscriptions.jsto Typescript and created their endpoint definitions on the rest-typings folder.Issue(s)
Steps to test or reproduce
Further comments