[FIX] Fixing Network connectivity issues with SIP client. #25391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: The previous PR did not handle the issues completely. This PR is expected to handle 1. Clearing call related UI when the network is disconnected or switched. 2. Do clean connectivity. There were few issues discovered in earlier implementation. e.g endpoint would randomly get disconnected after a while. This was due to the fact that the earlier socket disconnection caused the removal of contact on asterisk. This should be fixed in this PR. 3. This PR contains a lot of logs. This will be removed before the final merge.
Description: Fixing error.
Description: Removed log statents. Changed the call disconnection logic. The call now gets disconnected when the network disconnects. Earlier it would get disconnected when the network was restored back.
Description: Cleaning VoIPUser.ts.
KevLehman
reviewed
May 11, 2022
Description: Handling review comments
Description: Correctly handling the registration flag when network is restored.
KevLehman
previously approved these changes
May 20, 2022
Description: Fixing review comments.
KevLehman
approved these changes
May 23, 2022
MartinSchoeler
added a commit
that referenced
this pull request
May 23, 2022
gabriellsh
added a commit
that referenced
this pull request
May 23, 2022
…pinned-messages-display * 'develop' of github.com:RocketChat/Rocket.Chat: [NEW] Federation (Alpha Stabilization) (#25457) Chore: Convert to typescript some functions from app/lib/server/functions (#24519) [NEW] Add option to show mentions badge when show counter is disabled (#25329) [FIX] Fixing Network connectivity issues with SIP client. (#25391)
MartinSchoeler
added a commit
that referenced
this pull request
May 23, 2022
KevLehman
pushed a commit
that referenced
this pull request
May 23, 2022
gabriellsh
added a commit
that referenced
this pull request
May 23, 2022
…adMessagePreview * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) [FIX] Pinned Message display cutting off information (#25535) Chore: Dependencies upgrade (#25290) Chore: bump fuselage (#25605) [NEW] Federation (Alpha Stabilization) (#25457) Chore: Convert to typescript some functions from app/lib/server/functions (#24519) [NEW] Add option to show mentions badge when show counter is disabled (#25329) [FIX] Fixing Network connectivity issues with SIP client. (#25391) [FIX] Ordered and unordered list styles, Line breaks. (#25494) Chore: Convert slashCommands to typescript (#25592) [NEW] Get user's preferred language via apps (#25514) [NEW] Star message, report and delete message events (#25383) [NEW] Add new events after user login, logout and change his status (#25234) [NEW] Add new app events for pin, react and follow message (#25337) Chore: Convert AutoTranslate (#25591) Chore: Migrate retention-policy to ts (#25582) Chore: Convert to typescript the slash commands help files (#24307) Chore: Convert Create Channel (#25589) Chore: Convert additionalForms (#25586) Chore: Rewrite autotranslate to ts (#25425) [NEW] Add user events for apps (#25165) ...
ggazzo
pushed a commit
that referenced
this pull request
May 24, 2022
* Clickup Task: https://app.clickup.com/t/245c0d8 Description: The previous PR did not handle the issues completely. This PR is expected to handle 1. Clearing call related UI when the network is disconnected or switched. 2. Do clean connectivity. There were few issues discovered in earlier implementation. e.g endpoint would randomly get disconnected after a while. This was due to the fact that the earlier socket disconnection caused the removal of contact on asterisk. This should be fixed in this PR. 3. This PR contains a lot of logs. This will be removed before the final merge. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Fixing error. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Removed log statents. Changed the call disconnection logic. The call now gets disconnected when the network disconnects. Earlier it would get disconnected when the network was restored back. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Cleaning VoIPUser.ts. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Handling review comments * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Correctly handling the registration flag when network is restored. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Fixing review comments.
ggazzo
pushed a commit
that referenced
this pull request
May 24, 2022
ggazzo
pushed a commit
that referenced
this pull request
May 30, 2022
* Clickup Task: https://app.clickup.com/t/245c0d8 Description: The previous PR did not handle the issues completely. This PR is expected to handle 1. Clearing call related UI when the network is disconnected or switched. 2. Do clean connectivity. There were few issues discovered in earlier implementation. e.g endpoint would randomly get disconnected after a while. This was due to the fact that the earlier socket disconnection caused the removal of contact on asterisk. This should be fixed in this PR. 3. This PR contains a lot of logs. This will be removed before the final merge. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Fixing error. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Removed log statents. Changed the call disconnection logic. The call now gets disconnected when the network disconnects. Earlier it would get disconnected when the network was restored back. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Cleaning VoIPUser.ts. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Handling review comments * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Correctly handling the registration flag when network is restored. * Clickup Task: https://app.clickup.com/t/245c0d8 Description: Fixing review comments.
ggazzo
pushed a commit
that referenced
this pull request
May 30, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The previous PR #25170 did not handle the issues completely.
This PR is expected to handle
get disconnected after a while. This was due to the fact that the earlier socket disconnection caused the
removal of contact on asterisk. This should be fixed in this PR.
Issue(s)
Steps to test or reproduce
Further comments
Testing notes :
This PR should be tested be tested for working on above mentioned 3 points. Also, it should take care If any of the above thing happens while on call, the UI will be cleared correctly.
This is a test PR for testing things on PR environment. When committing this code, some logs need to be removed.