Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Convert additionalForms #25586

Merged
merged 2 commits into from
May 20, 2022
Merged

Chore: Convert additionalForms #25586

merged 2 commits into from
May 20, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented May 20, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@ggazzo ggazzo requested a review from a team as a code owner May 20, 2022 19:13
@ggazzo ggazzo added the eng day label May 20, 2022
Copy link
Contributor

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the forms seems to be broken, LGTM

@ggazzo ggazzo merged commit 66c7f18 into develop May 20, 2022
@ggazzo ggazzo deleted the chore/convert-ee-forms branch May 20, 2022 20:35
gabriellsh added a commit that referenced this pull request May 23, 2022
…adMessagePreview

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] Pinned Message display cutting off information (#25535)
  Chore: Dependencies upgrade (#25290)
  Chore: bump fuselage (#25605)
  [NEW] Federation (Alpha Stabilization) (#25457)
  Chore: Convert to typescript some functions from app/lib/server/functions (#24519)
  [NEW] Add option to show mentions badge when show counter is disabled (#25329)
  [FIX] Fixing Network connectivity issues with SIP client. (#25391)
  [FIX] Ordered and unordered list styles, Line breaks. (#25494)
  Chore: Convert slashCommands to typescript (#25592)
  [NEW] Get user's preferred language via apps (#25514)
  [NEW] Star message, report and delete message events (#25383)
  [NEW] Add new events after user login, logout and change his status (#25234)
  [NEW] Add new app events for pin, react and follow message (#25337)
  Chore: Convert AutoTranslate (#25591)
  Chore: Migrate retention-policy to ts (#25582)
  Chore: Convert to typescript the slash commands help files (#24307)
  Chore: Convert Create Channel (#25589)
  Chore: Convert additionalForms (#25586)
  Chore: Rewrite autotranslate to ts (#25425)
  [NEW] Add user events for apps (#25165)
  ...
ggazzo added a commit that referenced this pull request May 24, 2022
Co-authored-by: Martin <martin.schoeler@rocket.chat>
@d-gubert d-gubert mentioned this pull request May 31, 2022
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants