[NEW] Marketplace security tab app info page #25739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ogic part Implemented the structure of the security tab of the app info page, implemented the logic part of the privacy summary section, and implemented the first part of the permissions section. Will be implementing the all permissions state of the permissions section and the policies section next.
Implemented the rest of the logical part of the permissions section, now it shows the apps permissions in case it has a permissions array and shows the default permissions in case it doesn't.
…pp-info-page-security-tab
Integrated the Terms of service and Privacy policy links with their back-end data. Currently the tosLink and privacyLink are only available in staging, will be deployed before the merge of this branch.
…pp-info-page-security-tab
…pp-info-page-security-tab
Changed the name of the permission typoe to AppPermission to respect the naming conventions and to not create missing type errors.
FIxed a problem where the AppStatus button didn't have spacing between its icon and its text.
Make the price display badge component not show when the app is in update mode, since it would be empty in that situation.
Added a verification for the case in which the AppStatus button is still null, and consequently doesn't have a .action information to use.
…pp-info-page-security-tab
github-actions
bot
added
stat: ready to merge
ggazzo
approved these changes
Jun 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Created a new security tab for installed apps that displays information related to the given app security policies, terms of services, and necessary permissions for the use of the app.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments