Chore: Remove trash collection from models when not used #26628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
When a
trashCollection
is provided to a model, all removed records from that collection/model are also stored in the "trash collection", but this has a cost, every delete operation now has to perform afind
before actually removing the records.The issue is that very few places were actually fetching records from the trash collection.. So all this extra cost was actually wasted.
This PR removes the
trashCollection
from all models that are NOT performing atrashFind
.I can foresee immediate performance gain by removing the trash param from some collections with high amount of records removal like
NotificationQueue
,UsersSessions
andSessions
.Issue(s)
Steps to test or reproduce
Further comments