Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVE] Better descriptions for VoIP Settings #26877

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Sep 14, 2022

OC-43

This changes some titles and descriptions of VoIP Settings, I've decided to change the translations only for this, since changing the settings keys would require migrations and extensive changes to places that use said settings. I felt it was too
much for only design/naming changes.

image

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #26877 (6ca0d37) into develop (3023022) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 6ca0d37 differs from pull request most recent head dd0d7e2. Consider uploading reports for the commit dd0d7e2 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26877      +/-   ##
===========================================
+ Coverage    40.88%   40.93%   +0.05%     
===========================================
  Files          791      791              
  Lines        17809    17809              
  Branches      1928     1928              
===========================================
+ Hits          7281     7291      +10     
+ Misses       10232    10225       -7     
+ Partials       296      293       -3     
Flag Coverage Δ
e2e 40.93% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 21, 2022
@kodiakhq kodiakhq bot merged commit aef67a2 into develop Sep 21, 2022
@kodiakhq kodiakhq bot deleted the improve/voip-settings-descriptions branch September 21, 2022 18:54
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants