Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Improve service's licence check #27872

Merged
merged 3 commits into from Jan 30, 2023
Merged

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Shutdown the services if the check fail as well.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team January 27, 2023 14:47
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #27872 (ad419a2) into develop (77630df) will decrease coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27872      +/-   ##
===========================================
- Coverage    43.06%   42.02%   -1.04%     
===========================================
  Files          815      842      +27     
  Lines        17090    17607     +517     
  Branches      1938     2013      +75     
===========================================
+ Hits          7360     7400      +40     
- Misses        9464     9938     +474     
- Partials       266      269       +3     
Flag Coverage Δ
e2e 42.02% <ø> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 56aae78 into develop Jan 30, 2023
@kodiakhq kodiakhq bot deleted the improve-license-check branch January 30, 2023 14:14
gabriellsh added a commit that referenced this pull request Feb 6, 2023
….Chat into matrixSearch

* 'feat/federation-feat-2' of github.com:RocketChat/Rocket.Chat: (31 commits)
  fix: removing file wrongly merged on update merge
  [NEW] Federation search public rooms in the Matrix network (#27434)
  Chore: Refactor other kinds of message - Phase 2 (#27927)
  Chore: improve some e2e selectors (#27936)
  [NEW] Warning Popup reinforcing Zapier deprecation on Integrations Admin settings (#27744)
  Chore: Notify Marketplace on App Install (#27925)
  i18n: Language update from LingoHub 🤖 on 2023-01-23Z (#27814)
  [FIX][ENTERPRISE] DDP streamer sending data to destroyed streams (#27929)
  Chore: Migrate cached collections to TypeScript (#27909)
  i18n: Language update from LingoHub 🤖 on 2023-01-09Z (#27705)
  [FIX] Reduce re-subscription on `notify-room/user-activity` stream event (#27911)
  [FIX] Unread Message count not displayed for new messages in Omni-Rooms (#27539)
  Chore: Improve service's licence check (#27872)
  [IMPROVE] Livechat Persian translation (#27825)
  Chore(deps): Bump thehanimo/pr-title-checker from 1.3.4 to 1.3.6 (#27884)
  Chore: use useQuery in place of deprecated useEndpointData (#27673)
  Chore: Update Some Composer Icons (#27862)
  Regression: Undefined default message context (#27870)
  Chore: Remove OS version for device management (#27786)
  [BREAK] Remove less theming (#27647)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants