Chore: Notify Marketplace on App Install #27925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf336
force-pushed
the
chore/notify-marketplace
branch
from
fa0e4be
to
13d9543
Compare
Codecov Report
@@ Coverage Diff @@
## develop #27925 +/- ##
===========================================
- Coverage 41.94% 41.87% -0.07%
===========================================
Files 841 841
Lines 17624 17624
Branches 2071 2071
===========================================
- Hits 7392 7380 -12
- Misses 9955 9967 +12
Partials 277 277
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
the
stat: ready to merge
tiagoevanp
previously approved these changes
Feb 1, 2023
We do this to help with app requests and ensure the flow of the app requests are correctly handled.
graywolf336
force-pushed
the
chore/notify-marketplace
branch
from
ec9dfa8
to
329d48e
Compare
tiagoevanp
approved these changes
Feb 2, 2023
matheuslc
approved these changes
Feb 2, 2023
gabriellsh
added a commit
that referenced
this pull request
Feb 6, 2023
….Chat into matrixSearch * 'feat/federation-feat-2' of github.com:RocketChat/Rocket.Chat: (31 commits) fix: removing file wrongly merged on update merge [NEW] Federation search public rooms in the Matrix network (#27434) Chore: Refactor other kinds of message - Phase 2 (#27927) Chore: improve some e2e selectors (#27936) [NEW] Warning Popup reinforcing Zapier deprecation on Integrations Admin settings (#27744) Chore: Notify Marketplace on App Install (#27925) i18n: Language update from LingoHub 🤖 on 2023-01-23Z (#27814) [FIX][ENTERPRISE] DDP streamer sending data to destroyed streams (#27929) Chore: Migrate cached collections to TypeScript (#27909) i18n: Language update from LingoHub 🤖 on 2023-01-09Z (#27705) [FIX] Reduce re-subscription on `notify-room/user-activity` stream event (#27911) [FIX] Unread Message count not displayed for new messages in Omni-Rooms (#27539) Chore: Improve service's licence check (#27872) [IMPROVE] Livechat Persian translation (#27825) Chore(deps): Bump thehanimo/pr-title-checker from 1.3.4 to 1.3.6 (#27884) Chore: use useQuery in place of deprecated useEndpointData (#27673) Chore: Update Some Composer Icons (#27862) Regression: Undefined default message context (#27870) Chore: Remove OS version for device management (#27786) [BREAK] Remove less theming (#27647) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Notifies Rocket.Chat's Marketplace of an app install action. This correlates with the app request flow.
Issue(s)
Steps to test or reproduce
Mostly backend work. So, installing or updating an app shouldn't cause any errors as all errors are silenced intentionally.
Further comments
As mentioned above, the errors are silenced/ignored. This is a secondary route for app requests and we have a backup flow for if this method fails.