Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: More E2E tests for PDF transcript feature of Omnichannel #28110

Merged
merged 6 commits into from
Mar 1, 2023
Merged

Chore: More E2E tests for PDF transcript feature of Omnichannel #28110

merged 6 commits into from
Mar 1, 2023

Conversation

murtaza98
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@murtaza98 murtaza98 added this to the 6.0.0 milestone Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #28110 (c7aa36d) into develop (befece0) will increase coverage by 12.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28110       +/-   ##
============================================
+ Coverage    32.35%   44.79%   +12.44%     
============================================
  Files          629      766      +137     
  Lines        12538    14947     +2409     
  Branches      1866     2087      +221     
============================================
+ Hits          4057     6696     +2639     
+ Misses        8281     7956      -325     
- Partials       200      295       +95
Flag Coverage Δ
e2e 44.76% <ø> (+12.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 requested a review from a team February 21, 2023 16:09
@murtaza98 murtaza98 marked this pull request as ready for review February 21, 2023 16:10
@murtaza98 murtaza98 requested a review from a team as a code owner February 21, 2023 16:10
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 21, 2023
@sampaiodiego sampaiodiego removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2023
sampaiodiego
sampaiodiego approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has some conflicts with #28211

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 1, 2023
@kodiakhq kodiakhq bot merged commit b27665d into develop Mar 1, 2023
@kodiakhq kodiakhq bot deleted the omni-pdf-transcript-tests branch March 1, 2023 22:44
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@KevLehman KevLehman KevLehman approved these changes

Assignees
No one assigned
Labels
squad: omnichannel stat: QA skipped stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@murtaza98 @sampaiodiego @KevLehman