refactor: remove some Meteor.bindEnvironment #28822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28822 +/- ##
===========================================
+ Coverage 45.39% 45.43% +0.04%
===========================================
Files 728 728
Lines 14202 14202
Branches 2189 2189
===========================================
+ Hits 6447 6453 +6
+ Misses 7448 7445 -3
+ Partials 307 304 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
requested changes
Apr 6, 2023
apps/meteor/app/cloud/server/functions/getWorkspaceAccessTokenWithScope.js
Outdated
Show resolved
Hide resolved
…ocket.Chat into refactor/remove-meteor-bind
…ocket.Chat into refactor/remove-meteor-bind
MarcosSpessatto
commented
Apr 6, 2023
| @@ -46,6 +46,9 @@ Meteor.startup(function () { | |||
|
|
|||
| const file = await RocketChatFileCustomSoundsInstance.getFileWithReadStream(fileId); | |||
| if (!file) { | |||
| res.writeHead(404); | |||
There was a problem hiding this comment.
@sampaiodiego I've changed this to a 404 error because it was doing nothing here, leading to a timeout error. I don't think this should be considered a breaking change.
There was a problem hiding this comment.
that's great.. we desperately need tests these endpoints =)
edit: oh you did it already! 🎉
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
approved these changes
Apr 10, 2023
gabriellsh
added a commit
that referenced
this pull request
Apr 12, 2023
…hideSysMes * 'develop' of github.com:RocketChat/Rocket.Chat: (50 commits) fix: application crashing when clicking on "Files" button (#28878) revert: rate limiter bindEnvironment refactor: Changed settings registry's callbacks to work with async functions (#28784) revert: removal of `Meteor.bindEnvironment` on `DDPRateLimiter.addRule` (#28874) chore: Limit 10 usernames on reactions tooltip (#28141) fix: quote line break (#28798) fix: Add function to get installation source (#28806) regression: `fetch` call in `getWorkspaceAccessTokenWithScope` (#28866) fix(docs,readme): use raw image url (#28861) refactor: Make onLicense support async callbacks (#28791) refactor: remove some Meteor.bindEnvironment (#28822) refactor: Move callbacks to ts - 2 (#28771) chore: Update issue_template.md (#28753) fix: Fixed business hours route redirect (#28344) feat: add GA4 support (#28830) chore(deps): Prettier version (#28857) remove meteor.call from server (#28774) refactor: Remove fibers from `linkedin-oauth` (#28779) fix: Invalid JSON in Custom Translations setting crashes the UI (#28600) regression(e2e): Missing private key blocks sending message in encrypted rooms (#28831) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
ARCH-948
Issue(s)
Steps to test or reproduce
Further comments