Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed business hours route redirect #28344

Merged
merged 4 commits into from Apr 10, 2023
Merged

Conversation

aleksandernsilva
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR fixes the user being redirected to a blank page after editing the business hours.

Issue(s)

Steps to test or reproduce

Further comments

OC-272

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #28344 (78fb318) into develop (a966518) will increase coverage by 12.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28344       +/-   ##
============================================
+ Coverage    33.13%   45.38%   +12.25%     
============================================
  Files          611      728      +117     
  Lines        12150    14217     +2067     
  Branches      1948     2191      +243     
============================================
+ Hits          4026     6453     +2427     
+ Misses        7901     7460      -441     
- Partials       223      304       +81     
Flag Coverage Δ
e2e 45.34% <ø> (+12.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 10, 2023 16:51
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner March 10, 2023 16:51
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 20, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2023
@MartinSchoeler MartinSchoeler changed the title [FIX] Fixed business hours route redirect fix: Fixed business hours route redirect Mar 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 21, 2023
@aleksandernsilva aleksandernsilva added this to the 6.2.0 milestone Apr 10, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 10, 2023
@kodiakhq kodiakhq bot merged commit 0567163 into develop Apr 10, 2023
37 checks passed
@kodiakhq kodiakhq bot deleted the fix/business-hours-blank branch April 10, 2023 17:18
gabriellsh added a commit that referenced this pull request Apr 12, 2023
…hideSysMes

* 'develop' of github.com:RocketChat/Rocket.Chat: (50 commits)
  fix: application crashing when clicking on "Files" button (#28878)
  revert: rate limiter bindEnvironment
  refactor: Changed settings registry's callbacks to work with async functions (#28784)
  revert: removal of `Meteor.bindEnvironment` on `DDPRateLimiter.addRule` (#28874)
  chore: Limit 10 usernames on reactions tooltip (#28141)
  fix: quote line break (#28798)
  fix: Add function to get installation source (#28806)
  regression: `fetch` call in `getWorkspaceAccessTokenWithScope` (#28866)
  fix(docs,readme): use raw image url (#28861)
  refactor: Make onLicense support async callbacks (#28791)
  refactor: remove some Meteor.bindEnvironment (#28822)
  refactor: Move callbacks to ts - 2 (#28771)
  chore: Update issue_template.md (#28753)
  fix: Fixed business hours route redirect (#28344)
  feat: add GA4 support (#28830)
  chore(deps): Prettier version (#28857)
  remove meteor.call from server (#28774)
  refactor: Remove fibers from `linkedin-oauth` (#28779)
  fix: Invalid JSON in Custom Translations setting crashes the UI (#28600)
  regression(e2e): Missing private key blocks sending message in encrypted rooms (#28831)
  ...
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants