Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: fetch call in getWorkspaceAccessTokenWithScope #28866

Merged
merged 2 commits into from Apr 11, 2023

Conversation

tassoevan
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@tassoevan tassoevan changed the title fix: fetch call in getWorkspaceAccessTokenWithScope regression: fetch call in getWorkspaceAccessTokenWithScope Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #28866 (0168d25) into develop (f7c49e3) will increase coverage by 1.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28866      +/-   ##
===========================================
+ Coverage    44.07%   45.16%   +1.08%     
===========================================
  Files          704      727      +23     
  Lines        13798    14156     +358     
  Branches      2185     2187       +2     
===========================================
+ Hits          6081     6393     +312     
- Misses        7413     7456      +43     
- Partials       304      307       +3     
Flag Coverage Δ
e2e 45.11% <ø> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan marked this pull request as ready for review April 11, 2023 04:58
@tassoevan tassoevan added this to the 6.2.0 milestone Apr 11, 2023
@tassoevan tassoevan requested a review from a team April 11, 2023 04:58
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Apr 11, 2023
@kodiakhq kodiakhq bot merged commit e4f2798 into develop Apr 11, 2023
38 checks passed
@kodiakhq kodiakhq bot deleted the fix/fetch-call branch April 11, 2023 15:03
gabriellsh added a commit that referenced this pull request Apr 12, 2023
…hideSysMes

* 'develop' of github.com:RocketChat/Rocket.Chat: (50 commits)
  fix: application crashing when clicking on "Files" button (#28878)
  revert: rate limiter bindEnvironment
  refactor: Changed settings registry's callbacks to work with async functions (#28784)
  revert: removal of `Meteor.bindEnvironment` on `DDPRateLimiter.addRule` (#28874)
  chore: Limit 10 usernames on reactions tooltip (#28141)
  fix: quote line break (#28798)
  fix: Add function to get installation source (#28806)
  regression: `fetch` call in `getWorkspaceAccessTokenWithScope` (#28866)
  fix(docs,readme): use raw image url (#28861)
  refactor: Make onLicense support async callbacks (#28791)
  refactor: remove some Meteor.bindEnvironment (#28822)
  refactor: Move callbacks to ts - 2 (#28771)
  chore: Update issue_template.md (#28753)
  fix: Fixed business hours route redirect (#28344)
  feat: add GA4 support (#28830)
  chore(deps): Prettier version (#28857)
  remove meteor.call from server (#28774)
  refactor: Remove fibers from `linkedin-oauth` (#28779)
  fix: Invalid JSON in Custom Translations setting crashes the UI (#28600)
  regression(e2e): Missing private key blocks sending message in encrypted rooms (#28831)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants