refactor: Move units check outside of model for finds #29253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevLehman
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #29253 +/- ##
===========================================
- Coverage 45.76% 36.66% -9.11%
===========================================
Files 687 605 -82
Lines 12957 11325 -1632
Branches 2217 2031 -186
===========================================
- Hits 5930 4152 -1778
- Misses 6709 6911 +202
+ Partials 318 262 -56
Flags with carried forward coverage won't be shown. Click here to find out more. |
🦋 Changeset detectedLatest commit: eeb8a23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
murtaza98
reviewed
May 24, 2023
murtaza98
reviewed
May 24, 2023
apps/meteor/ee/app/livechat-enterprise/server/lib/query.helper.js
Outdated
Show resolved
Hide resolved
…b.com:RocketChat/Rocket.Chat into improve/move-unit-check-on-find-outside-model
murtaza98
previously approved these changes
May 25, 2023
murtaza98
previously approved these changes
Jun 5, 2023
dionisio-bot
bot
added
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
dionisio-bot
bot
added
the
stat: ready to merge
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
…b.com:RocketChat/Rocket.Chat into improve/move-unit-check-on-find-outside-model
dionisio-bot
bot
added
stat: ready to merge
ggazzo
approved these changes
Jun 13, 2023
aleksandernsilva
approved these changes
Jun 13, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OC-950
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
findandfindpaginatedfunctions.Promise.awaitintroduced to fix a regression on 6.2