Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Editing a department shows incorrect data #29468

Merged
merged 7 commits into from
Jun 13, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Jun 6, 2023

Proposed changes (including videos or screenshots)

This PR fixes an issue where editing a department was showing data from the previously edited department

Issue(s)

OC-608
OC-1033

Steps to test or reproduce

  1. Archive a department say A
  2. Unarchive the same department.
  3. Click on department B.

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: ce3ce71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #29468 (ce3ce71) into develop (c0cb917) will decrease coverage by 6.86%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #29468      +/-   ##
===========================================
- Coverage    46.54%   39.68%   -6.86%     
===========================================
  Files          700      659      -41     
  Lines        13044    12495     -549     
  Branches      2235     2186      -49     
===========================================
- Hits          6071     4959    -1112     
- Misses        6647     7237     +590     
+ Partials       326      299      -27     
Flag Coverage Δ
e2e 39.67% <ø> (-6.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review June 6, 2023 16:22
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner June 6, 2023 16:22
@aleksandernsilva aleksandernsilva added this to the 6.3.0 milestone Jun 6, 2023
MartinSchoeler
MartinSchoeler previously approved these changes Jun 6, 2023
@aleksandernsilva aleksandernsilva changed the title fix: Editing a department was showing the previous data fix: Editing a department shows incorrect data Jun 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jun 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 13, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jun 13, 2023
@kodiakhq kodiakhq bot merged commit 760c023 into develop Jun 13, 2023
36 of 37 checks passed
@kodiakhq kodiakhq bot deleted the fix/edit-department-prev-data branch June 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants