Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove livechat.js file #31179

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

KevLehman
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 7, 2023

⚠️ No Changeset found

Latest commit: 398ba94

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #31179 (398ba94) into develop (6f88d8d) will decrease coverage by 8.92%.
The diff coverage is 42.85%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31179      +/-   ##
===========================================
- Coverage    57.77%   48.85%   -8.92%     
===========================================
  Files          885     3272    +2387     
  Lines        20228    80271   +60043     
  Branches      3766    16317   +12551     
===========================================
+ Hits         11687    39220   +27533     
- Misses        7848    36432   +28584     
- Partials       693     4619    +3926     
Flag Coverage Δ
e2e 51.34% <ø> (+8.98%) ⬆️
e2e-api 40.67% <42.85%> (?)
unit 77.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review December 7, 2023 14:56
@KevLehman KevLehman requested a review from a team as a code owner December 7, 2023 14:56
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 7, 2023
@murtaza98 murtaza98 added stat: needs QA squad: omnichannel and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 7, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 7, 2023
@murtaza98 murtaza98 removed the stat: ready to merge PR tested and approved waiting for merge label Dec 7, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 7, 2023
@KevLehman KevLehman removed the stat: ready to merge PR tested and approved waiting for merge label Dec 7, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Dec 7, 2023
@kodiakhq kodiakhq bot merged commit d7905a3 into develop Dec 7, 2023
55 of 56 checks passed
@kodiakhq kodiakhq bot deleted the refactor/bye-bye-livechatjs branch December 7, 2023 15:26
gabriellsh added a commit that referenced this pull request Dec 7, 2023
…hideUi

* 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits)
  chore: Rename useFileInput to useSingleFileInput (#31186)
  regression: FED-116 allow to invite rc users to fed channels (#30658)
  refactor: Remove `livechat.js` file (#31179)
  test: Fix Analytics test to use always same date (#31178)
  chore: notify messages on emails incoming and outgoing (#30925)
  chore: add msg stream to the federation v1 feature (#31105)
  chore: update editedBy when the user changes their username (following BE rules) (#31098)
  chore: add a manual msg stream update for autotranslate (#31094)
  chore: send streaming msg update on livechat decline call event (#31025)
  chore: Replace `IconButton` in favor of `Button` on `PageHeader` (#31171)
  refactor: Migrate `analytics.js` to service (#31051)
  feat: Add `push.info` endpoint to retrieve push gateway info (#30868)
  chore: Convert Importer classes to typescript (#29714)
  docs: fix lost image render in markdown (#31013)
  feat(uikit): Move `@rocket.chat/ui-kit` package to the main monorepo (#31138)
  i18n: Language update from LingoHub 🤖 on 2023-12-05Z (#31161)
  feat: Skip to main content shortcut and `useDocumentTitle` (#30680)
  chore: Replace `useForm` in favor of RHF on Omnichannel `AgentsEdit` (#30789)
  chore: ImageGallery tweaks (#31159)
  fix: New `custom-roles` license module isn't properly checked (#31153)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants