chore: Convert Importer classes to typescript #29714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pierre-lehnen-rc
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #29714 +/- ##
===========================================
- Coverage 57.18% 54.87% -2.32%
===========================================
Files 880 1583 +703
Lines 19925 31145 +11220
Branches 3719 6401 +2682
===========================================
+ Hits 11395 17091 +5696
- Misses 7841 12715 +4874
- Partials 689 1339 +650
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
force-pushed
the
chore/convert-importer-to-ts
branch
2 times, most recently
from
25761ef
to
4f589c7
Compare
pierre-lehnen-rc
added a commit
that referenced
this pull request
Jul 27, 2023
pierre-lehnen-rc
changed the title
…e/convert-importer-to-ts
…e/convert-importer-to-ts
…e/convert-importer-to-ts
…e/convert-importer-to-ts
…e/convert-importer-to-ts
tassoevan
approved these changes
Nov 3, 2023
MarcosSpessatto
approved these changes
Nov 3, 2023
gabriellsh
added a commit
that referenced
this pull request
Dec 7, 2023
…hideUi * 'develop' of github.com:RocketChat/Rocket.Chat: (21 commits) chore: Rename useFileInput to useSingleFileInput (#31186) regression: FED-116 allow to invite rc users to fed channels (#30658) refactor: Remove `livechat.js` file (#31179) test: Fix Analytics test to use always same date (#31178) chore: notify messages on emails incoming and outgoing (#30925) chore: add msg stream to the federation v1 feature (#31105) chore: update editedBy when the user changes their username (following BE rules) (#31098) chore: add a manual msg stream update for autotranslate (#31094) chore: send streaming msg update on livechat decline call event (#31025) chore: Replace `IconButton` in favor of `Button` on `PageHeader` (#31171) refactor: Migrate `analytics.js` to service (#31051) feat: Add `push.info` endpoint to retrieve push gateway info (#30868) chore: Convert Importer classes to typescript (#29714) docs: fix lost image render in markdown (#31013) feat(uikit): Move `@rocket.chat/ui-kit` package to the main monorepo (#31138) i18n: Language update from LingoHub 🤖 on 2023-12-05Z (#31161) feat: Skip to main content shortcut and `useDocumentTitle` (#30680) chore: Replace `useForm` in favor of RHF on Omnichannel `AgentsEdit` (#30789) chore: ImageGallery tweaks (#31159) fix: New `custom-roles` license module isn't properly checked (#31153) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Some refactoring in the importer classes:
Issue(s)
Steps to test or reproduce
Further comments