feat: Add contentDisposition option to file storages #31974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 64e29e0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31974 +/- ##
===========================================
+ Coverage 56.32% 56.34% +0.01%
===========================================
Files 2434 2434
Lines 53708 53708
Branches 11057 11057
===========================================
+ Hits 30251 30260 +9
+ Misses 20812 20804 -8
+ Partials 2645 2644 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Mar 13, 2024
apps/meteor/client/components/message/content/attachments/file/GenericFileAttachment.tsx
Show resolved
Hide resolved
….Chat into fix-pdf-viewer
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Looks like this PR is not ready to merge, because of the following issues:
|
jeanfbrito
changed the title
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
KevLehman
requested changes
May 20, 2024
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
KevLehman
previously approved these changes
May 20, 2024
dionisio-bot
bot
added
the
stat: ready to merge
sampaiodiego
requested changes
May 24, 2024
Co-authored-by: Diego Sampaio <chinello@gmail.com>
sampaiodiego
approved these changes
May 28, 2024
MarcosSpessatto
approved these changes
May 28, 2024
KevLehman
approved these changes
May 28, 2024
csuadev
approved these changes
May 29, 2024
matheusbsilva137
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: Marcos Spessatto Defendi <15324204+MarcosSpessatto@users.noreply.github.com>
gabriellsh
added a commit
that referenced
this pull request
Jun 3, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: Release 6.9.0 Release 6.9.0-rc.2 fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500) fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500) regression: Hide prune section based on permission (#32531) fix: Users in role table not rendering the empty state properly (#32412) refactor: EmailInbox out of DB Watcher (#32501) ci: increase issue allowed stale time (#32523) regression: Remove impossible sorting from users table "registration status" column (#32506) feat: Add contentDisposition option to file storages (#31974) i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-05-28Z (#32508) Release 6.9.0-rc.1 fix: Re-login same browser tab issues (#32479) regression: Replace read receipt single icon (#32486) regression: Incorrect retention policy banner's display rule for teams (#32483) chore: Publish npm packages again (#32463) ci: publish missing Omnichannel services to DockerHub (#32462) Release 6.9.0-rc.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Add the option to change
contentDispositionon the download url for file uploads.So we can make GridFS and FileSystem work with PDF viewer on desktop.
Issue(s)
SUP-516
SUP-494
Steps to test or reproduce
Further comments