fix!: LDAP sync triggers multiple cron jobs in case an invalid sync interval is provided

.changeset/chilled-boats-sip.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+This adjustment removes the deprecated `eraseRoom` method. Moving forward, use the `room.delete` endpoint to delete rooms.

.changeset/fair-seahorses-laugh.md

@@ -0,0 +1,13 @@
+---
+'@rocket.chat/meteor': major
+---
+
+As per MongoDB Lifecycle Schedules ([mongodb.com/legal/support-policy/lifecycles](https://www.mongodb.com/legal/support-policy/lifecycles)) we're removing official support to MongoDB version 4.4 that has reached end of life in February 2024.
+
+We recommend upgrading to at least MongoDB 6.0+, though 5.0 is still a supported version.
+
+Here are official docs on how to upgrade to some of the supported versions:
+
+- [mongodb.com/docs/manual/release-notes/5.0-upgrade-replica-set](https://www.mongodb.com/docs/manual/release-notes/5.0-upgrade-replica-set/)
+- [mongodb.com/docs/manual/release-notes/6.0-upgrade-replica-set](https://www.mongodb.com/docs/manual/release-notes/6.0-upgrade-replica-set/)
+- [mongodb.com/docs/manual/release-notes/7.0-upgrade-replica-set](https://www.mongodb.com/docs/manual/release-notes/7.0-upgrade-replica-set/)

.changeset/fluffy-knives-count.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": major
+---
+
+Added MongoDB 7.0 support 

.changeset/fuzzy-cherries-buy.md

@@ -0,0 +1,7 @@
+---
+"@rocket.chat/meteor": major
+---
+
+Api login should not suggest which credential is wrong (password/username)
+
+Failed login attemps will always return `Unauthorized` instead of the internal fail reason

.changeset/gold-knives-sparkle.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': patch
+---
+
+Fixes an issue where ignore threads parameter were not being affected by retention policy overriding in old channels

.changeset/lovely-trees-call.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": major
+---
+
+Removes `view-history` permission due to lack of usage

.changeset/quiet-kings-rhyme.md

@@ -0,0 +1,5 @@
+---
+'@rocket.chat/meteor': major
+---
+
+Removed the ability to import data in the HipChat Enterprise format, as it was discontinued over five years ago.

.changeset/sixty-vans-grab.md

@@ -0,0 +1,5 @@
+---
+"@rocket.chat/meteor": major
+---
+
+Fixed issue with LDAP sync triggering multiple cron jobs in case an invalid sync interval is provided

.changeset/tiny-rice-train.md

@@ -0,0 +1,6 @@
+---
+"@rocket.chat/meteor": major
+"@rocket.chat/rest-typings": major
+---
+
+Removed `meteor/check` from `chat` endpoints

.github/workflows/ci-test-e2e.yml

@@ -29,7 +29,7 @@ on:
       transporter:
         type: string
       mongodb-version:
-        default: "['4.4', '6.0']"
+        default: "['5.0', '7.0']"
         required: false
         type: string
       release:
@@ -80,16 +80,16 @@ jobs:
   test:
     runs-on: ubuntu-20.04
     env:
-      RC_DOCKERFILE: ${{ matrix.mongodb-version == '6.0' && inputs.rc-dockerfile-alpine || inputs.rc-dockerfile }}
-      RC_DOCKER_TAG: ${{ matrix.mongodb-version == '6.0' && inputs.rc-docker-tag-alpine || inputs.rc-docker-tag }}
+      RC_DOCKERFILE: ${{ matrix.mongodb-version == '7.0' && inputs.rc-dockerfile-alpine || inputs.rc-dockerfile }}
+      RC_DOCKER_TAG: ${{ matrix.mongodb-version == '7.0' && inputs.rc-docker-tag-alpine || inputs.rc-docker-tag }}
 
     strategy:
       fail-fast: false
       matrix:
         mongodb-version: ${{ fromJSON(inputs.mongodb-version) }}
         shard: ${{ fromJSON(inputs.shard) }}
 
-    name: MongoDB ${{ matrix.mongodb-version }}${{ inputs.db-watcher-disabled == 'true' && ' [no watchers]' || '' }} (${{ matrix.shard }}/${{ inputs.total-shard }})${{ matrix.mongodb-version == '6.0' && ' - Alpine' || '' }}
+    name: MongoDB ${{ matrix.mongodb-version }}${{ inputs.db-watcher-disabled == 'true' && ' [no watchers]' || '' }} (${{ matrix.shard }}/${{ inputs.total-shard }})${{ matrix.mongodb-version == '7.0' && ' - Alpine' || '' }}
 
     steps:
       - name: Collect Workflow Telemetry

.github/workflows/ci.yml

@@ -121,7 +121,7 @@ jobs:
           fi;
 
           curl -H "Content-Type: application/json" -H "X-Update-Token: $UPDATE_TOKEN" -d \
-              "{\"nodeVersion\": \"${{ needs.release-versions.outputs.node-version }}\", \"compatibleMongoVersions\": [\"4.4\", \"5.0\", \"6.0\"], \"commit\": \"$GITHUB_SHA\", \"tag\": \"$RC_VERSION\", \"branch\": \"$GIT_BRANCH\", \"artifactName\": \"$ARTIFACT_NAME\", \"releaseType\": \"draft\", \"draftAs\": \"$RC_RELEASE\"}" \
+              "{\"nodeVersion\": \"${{ needs.release-versions.outputs.node-version }}\", \"compatibleMongoVersions\": [\"5.0\", \"6.0\", \"7.0\"], \"commit\": \"$GITHUB_SHA\", \"tag\": \"$RC_VERSION\", \"branch\": \"$GIT_BRANCH\", \"artifactName\": \"$ARTIFACT_NAME\", \"releaseType\": \"draft\", \"draftAs\": \"$RC_RELEASE\"}" \
               https://releases.rocket.chat/update
 
   packages-build:
@@ -366,7 +366,7 @@ jobs:
       release: ee
       transporter: 'nats://nats:4222'
       enterprise-license: ${{ needs.release-versions.outputs.enterprise-license }}
-      mongodb-version: "['4.4']"
+      mongodb-version: "['5.0']"
       node-version: ${{ needs.release-versions.outputs.node-version }}
       lowercase-repo: ${{ needs.release-versions.outputs.lowercase-repo }}
       rc-dockerfile: ${{ needs.release-versions.outputs.rc-dockerfile }}
@@ -390,7 +390,7 @@ jobs:
       enterprise-license: ${{ needs.release-versions.outputs.enterprise-license }}
       shard: '[1, 2, 3, 4, 5]'
       total-shard: 5
-      mongodb-version: "['4.4']"
+      mongodb-version: "['5.0']"
       node-version: ${{ needs.release-versions.outputs.node-version }}
       lowercase-repo: ${{ needs.release-versions.outputs.lowercase-repo }}
       rc-dockerfile: ${{ needs.release-versions.outputs.rc-dockerfile }}
@@ -802,7 +802,7 @@ jobs:
           fi;
 
           curl -H "Content-Type: application/json" -H "X-Update-Token: $UPDATE_TOKEN" -d \
-              "{\"nodeVersion\": \"${{ needs.release-versions.outputs.node-version }}\", \"compatibleMongoVersions\": [\"4.4\", \"5.0\", \"6.0\"], \"commit\": \"$GITHUB_SHA\", \"tag\": \"$RC_VERSION\", \"branch\": \"$GIT_BRANCH\", \"artifactName\": \"$ARTIFACT_NAME\", \"releaseType\": \"$RC_RELEASE\"}" \
+              "{\"nodeVersion\": \"${{ needs.release-versions.outputs.node-version }}\", \"compatibleMongoVersions\": [\"5.0\", \"6.0\", \"7.0\"], \"commit\": \"$GITHUB_SHA\", \"tag\": \"$RC_VERSION\", \"branch\": \"$GIT_BRANCH\", \"artifactName\": \"$ARTIFACT_NAME\", \"releaseType\": \"$RC_RELEASE\"}" \
               https://releases.rocket.chat/update
 
           # Makes build fail if the release isn't there

FEATURES.md

@@ -33,7 +33,6 @@
   - Incoming / Outgoing Webhooks
   - Data Importer
     - Import from Slack
-    - Import from Hipchat
   - Slack Bridge
 - Profiles
   - Custom avatars

apps/meteor/app/api/server/v1/assets.ts

@@ -1,7 +1,6 @@
 import { isAssetsUnsetAssetProps } from '@rocket.chat/rest-typings';
-import { Meteor } from 'meteor/meteor';
 
-import { RocketChatAssets } from '../../../assets/server';
+import { RocketChatAssets, setAsset, unsetAsset, refreshClients } from '../../../assets/server';
 import { settings } from '../../../settings/server';
 import { API } from '../api';
 import { getUploadFormData } from '../lib/getUploadFormData';
@@ -27,12 +26,12 @@ API.v1.addRoute(
 
 			const isValidAsset = assetsKeys.includes(assetName);
 			if (!isValidAsset) {
-				throw new Meteor.Error('error-invalid-asset', 'Invalid asset');
+				throw new Error('Invalid asset');
 			}
 
-			await Meteor.callAsync('setAsset', fileBuffer, mimetype, assetName);
+			await setAsset(this.userId, fileBuffer, mimetype, assetName);
 			if (refreshAllClients) {
-				await Meteor.callAsync('refreshClients');
+				await refreshClients(this.userId);
 			}
 
 			return API.v1.success();
@@ -51,11 +50,11 @@ API.v1.addRoute(
 			const { assetName, refreshAllClients } = this.bodyParams;
 			const isValidAsset = Object.keys(RocketChatAssets.assets).includes(assetName);
 			if (!isValidAsset) {
-				throw new Meteor.Error('error-invalid-asset', 'Invalid asset');
+				throw Error('Invalid asset');
 			}
-			await Meteor.callAsync('unsetAsset', assetName);
+			await unsetAsset(this.userId, assetName);
 			if (refreshAllClients) {
-				await Meteor.callAsync('refreshClients');
+				await refreshClients(this.userId);
 			}
 			return API.v1.success();
 		},

apps/meteor/app/api/server/v1/banners.ts

@@ -1,6 +1,5 @@
 import { Banner } from '@rocket.chat/core-services';
-import { BannerPlatform } from '@rocket.chat/core-typings';
-import { Match, check } from 'meteor/check';
+import { isBannersDismissProps, isBannersGetNewProps, isBannersProps } from '@rocket.chat/rest-typings';
 
 import { API } from '../api';
 
@@ -52,17 +51,10 @@ import { API } from '../api';
  */
 API.v1.addRoute(
 	'banners.getNew',
-	{ authRequired: true, deprecation: { version: '8.0.0', alternatives: ['banners/:id', 'banners'] } },
+	{ authRequired: true, validateParams: isBannersGetNewProps, deprecation: { version: '8.0.0', alternatives: ['banners/:id', 'banners'] } },
 	{
+		// deprecated
 		async get() {
-			check(
-				this.queryParams,
-				Match.ObjectIncluding({
-					platform: Match.OneOf(...Object.values(BannerPlatform)),
-					bid: Match.Maybe(String),
-				}),
-			);
-
 			const { platform, bid: bannerId } = this.queryParams;
 
 			const banners = await Banner.getBannersForUser(this.userId, platform, bannerId ?? undefined);
@@ -120,23 +112,10 @@ API.v1.addRoute(
  */
 API.v1.addRoute(
 	'banners/:id',
-	{ authRequired: true },
+	{ authRequired: true, validateParams: isBannersProps },
 	{
 		// TODO: move to users/:id/banners
 		async get() {
-			check(
-				this.urlParams,
-				Match.ObjectIncluding({
-					id: Match.Where((id: unknown): id is string => typeof id === 'string' && Boolean(id.trim())),
-				}),
-			);
-			check(
-				this.queryParams,
-				Match.ObjectIncluding({
-					platform: Match.OneOf(...Object.values(BannerPlatform)),
-				}),
-			);
-
 			const { platform } = this.queryParams;
 			const { id } = this.urlParams;
 
@@ -186,16 +165,9 @@ API.v1.addRoute(
  */
 API.v1.addRoute(
 	'banners',
-	{ authRequired: true },
+	{ authRequired: true, validateParams: isBannersProps },
 	{
 		async get() {
-			check(
-				this.queryParams,
-				Match.ObjectIncluding({
-					platform: Match.OneOf(...Object.values(BannerPlatform)),
-				}),
-			);
-
 			const { platform } = this.queryParams;
 
 			const banners = await Banner.getBannersForUser(this.userId, platform);
@@ -240,16 +212,9 @@ API.v1.addRoute(
  */
 API.v1.addRoute(
 	'banners.dismiss',
-	{ authRequired: true },
+	{ authRequired: true, validateParams: isBannersDismissProps },
 	{
 		async post() {
-			check(
-				this.bodyParams,
-				Match.ObjectIncluding({
-					bannerId: Match.Where((id: unknown): id is string => typeof id === 'string' && Boolean(id.trim())),
-				}),
-			);
-
 			const { bannerId } = this.bodyParams;
 
 			await Banner.dismiss(this.userId, bannerId);

apps/meteor/app/api/server/v1/channels.ts

@@ -23,11 +23,12 @@ import {
 import { Meteor } from 'meteor/meteor';
 
 import { isTruthy } from '../../../../lib/isTruthy';
+import { eraseRoom } from '../../../../server/lib/eraseRoom';
 import { findUsersOfRoom } from '../../../../server/lib/findUsersOfRoom';
 import { hideRoomMethod } from '../../../../server/methods/hideRoom';
 import { removeUserFromRoomMethod } from '../../../../server/methods/removeUserFromRoom';
 import { canAccessRoomAsync } from '../../../authorization/server';
-import { hasPermissionAsync, hasAtLeastOnePermissionAsync } from '../../../authorization/server/functions/hasPermission';
+import { hasPermissionAsync } from '../../../authorization/server/functions/hasPermission';
 import { saveRoomSettings } from '../../../channel-settings/server/methods/saveRoomSettings';
 import { mountIntegrationQueryBasedOnPermissions } from '../../../integrations/server/lib/mountQueriesBasedOnPermission';
 import { addUsersToRoomMethod } from '../../../lib/server/methods/addUsersToRoom';
@@ -272,6 +273,7 @@ API.v1.addRoute(
 	{
 		authRequired: true,
 		validateParams: isChannelsMessagesProps,
+		permissionsRequired: ['view-c-room'],
 	},
 	{
 		async get() {
@@ -292,9 +294,6 @@ API.v1.addRoute(
 			) {
 				return API.v1.unauthorized();
 			}
-			if (!(await hasPermissionAsync(this.userId, 'view-c-room'))) {
-				return API.v1.unauthorized();
-			}
 
 			const { cursor, totalCount } = await Messages.findPaginated(ourQuery, {
 				sort: sort || { ts: -1 },
@@ -465,7 +464,7 @@ API.v1.addRoute(
 				checkedArchived: false,
 			});
 
-			await Meteor.callAsync('eraseRoom', room._id);
+			await eraseRoom(room._id, this.userId);
 
 			return API.v1.success();
 		},
@@ -477,13 +476,10 @@ API.v1.addRoute(
 	{
 		authRequired: true,
 		validateParams: isChannelsConvertToTeamProps,
+		permissionsRequired: ['create-team'],
 	},
 	{
 		async post() {
-			if (!(await hasPermissionAsync(this.userId, 'create-team'))) {
-				return API.v1.unauthorized();
-			}
-
 			const { channelId, channelName } = this.bodyParams;
 
 			if (!channelId && !channelName) {
@@ -855,20 +851,22 @@ API.v1.addRoute(
 
 API.v1.addRoute(
 	'channels.getIntegrations',
-	{ authRequired: true },
 	{
-		async get() {
-			if (
-				!(await hasAtLeastOnePermissionAsync(this.userId, [
+		authRequired: true,
+		permissionsRequired: {
+			GET: {
+				permissions: [
 					'manage-outgoing-integrations',
 					'manage-own-outgoing-integrations',
 					'manage-incoming-integrations',
 					'manage-own-incoming-integrations',
-				]))
-			) {
-				return API.v1.unauthorized();
-			}
-
+				],
+				operation: 'hasAny',
+			},
+		},
+	},
+	{
+		async get() {
 			const findResult = await findChannelByIdOrName({
 				params: this.queryParams,
 				checkedArchived: false,
@@ -954,7 +952,12 @@ API.v1.addRoute(
 
 API.v1.addRoute(
 	'channels.list',
-	{ authRequired: true },
+	{
+		authRequired: true,
+		permissionsRequired: {
+			GET: { permissions: ['view-c-room', 'view-joined-room'], operation: 'hasAny' },
+		},
+	},
 	{
 		async get() {
 			const { offset, count } = await getPaginationItems(this.queryParams);
@@ -964,9 +967,6 @@ API.v1.addRoute(
 			const ourQuery: Record<string, any> = { ...query, t: 'c' };
 
 			if (!hasPermissionToSeeAllPublicChannels) {
-				if (!(await hasPermissionAsync(this.userId, 'view-joined-room'))) {
-					return API.v1.unauthorized();
-				}
 				const roomIds = (
 					await Subscriptions.findByUserIdAndType(this.userId, 'c', {
 						projection: { rid: 1 },