fix!: LDAP sync triggers multiple cron jobs in case an invalid sync interval is provided #32285
+52
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Diego Sampaio <chinello@gmail.com>
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: fe1a4c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32285 +/- ##
=================================================
- Coverage 55.59% 55.53% -0.06%
=================================================
Files 2427 2410 -17
Lines 53337 53074 -263
Branches 10970 10909 -61
=================================================
- Hits 29651 29475 -176
+ Misses 21050 20979 -71
+ Partials 2636 2620 -16
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
MarcosSpessatto
requested changes
Apr 26, 2024
ggazzo
dismissed
MarcosSpessatto’s stale review
The merge-base changed after approval.
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* chore: Improve permission check on channels endpoints
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…Chat into fix/ldap-triggers-multiple-cron-jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
packageValues as the fallback value in case the provided value is invalid;packageValues (from cron description to actual cron expressions, which is the type of value expected by RC since 6.3).Issue(s)
Steps to test or reproduce
Go to Settings > LDAP > Premium and set an invalid Avatar Background Sync Interval or Auto Logout Interval.
Current behavior: cron jobs are triggered successively (there is no interval between them).
Expected behavior: cron jobs intervals should follow each setting's default value instead.
Further comments
CORE-273