-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on permissions endpoints #32343
chore!: Improve permissions check on permissions endpoints #32343
Conversation
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32343 +/- ##
=================================================
+ Coverage 54.41% 55.53% +1.11%
=================================================
Files 2325 2405 +80
Lines 51772 52926 +1154
Branches 10654 10872 +218
=================================================
+ Hits 28172 29390 +1218
+ Misses 21090 20929 -161
- Partials 2510 2607 +97
Flags with carried forward coverage won't be shown. Click here to find out more. |
Co-authored-by: Diego Sampaio <chinello@gmail.com>
* chore: Improve permission check on channels endpoints
Proposed changes (including videos or screenshots)
permissions
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-345
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.