-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove message column on moderation console #32432
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32432 +/- ##
===========================================
+ Coverage 55.60% 56.03% +0.43%
===========================================
Files 2408 2456 +48
Lines 53023 54011 +988
Branches 10902 11120 +218
===========================================
+ Hits 29483 30265 +782
- Misses 20931 21086 +155
- Partials 2609 2660 +51
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/admin/moderation/ModerationConsoleTableRow.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/admin/moderation/ModerationConsoleTableRow.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the PR fixes the problem, we need to change the PR title to fix:
and add a changeset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to fix the indentation of the tests files?
get btnOptionQuoteMessage(): Locator { | ||
return this.page.getByRole('button', { name: 'Quote' }); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need this anymore...
This PR removes the message preview from the Moderation Console since it didn't wasn't useful for the admin and we need to lead them to click on the reports from a user to see all the messages from that specific user and check if any moderation is needed.
Proposed changes (including videos or screenshots)
Before:
After:
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-4
Steps to test or reproduce
Further comments