Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove message column on moderation console #32432

Merged
merged 12 commits into from
Jun 14, 2024

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented May 14, 2024

This PR removes the message preview from the Moderation Console since it didn't wasn't useful for the admin and we need to lead them to click on the reports from a user to see all the messages from that specific user and check if any moderation is needed.

Proposed changes (including videos or screenshots)

Before:
image

After:
image

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-4

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 14, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: f8488d7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.18%. Comparing base (97eaa17) to head (f8488d7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32432      +/-   ##
===========================================
- Coverage    56.48%   56.18%   -0.30%     
===========================================
  Files         2455     2449       -6     
  Lines        54100    53933     -167     
  Branches     11149    11127      -22     
===========================================
- Hits         30559    30304     -255     
- Misses       20890    20987      +97     
+ Partials      2651     2642       -9     
Flag Coverage Δ
e2e 56.20% <ø> (-0.02%) ⬇️
unit 72.01% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review May 16, 2024 08:54
@csuadev csuadev requested a review from a team as a code owner May 16, 2024 08:54
@csuadev csuadev added this to the 7.0 milestone May 20, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR fixes the problem, we need to change the PR title to fix: and add a changeset.

apps/meteor/tests/e2e/message-moderation.spec.ts Outdated Show resolved Hide resolved
@csuadev csuadev changed the title chore: reported message text on quoted message chore: remove message text on moderation console Jun 6, 2024
@csuadev csuadev changed the title chore: remove message text on moderation console chore: remove message column on moderation console Jun 6, 2024
@csuadev csuadev requested a review from dougfabris June 6, 2024 10:49
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to fix the indentation of the tests files?

MarcosSpessatto
MarcosSpessatto previously approved these changes Jun 7, 2024
@csuadev csuadev added the stat: QA assured Means it has been tested and approved by a company insider label Jun 12, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 12, 2024
@kodiakhq kodiakhq bot merged commit d3ab416 into develop Jun 14, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the fix/CORE-4-moderation-quoted-message branch June 14, 2024 14:50
gabriellsh added a commit that referenced this pull request Jun 18, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Not possible to edit room without proper permission with retention policy enabled (#32547)
  feat: Apps-Engine Deno Runtime update (#31821)
  feat: E2EE room setup header (#32446)
  fix: E2EE thread main message reactivity (#32381)
  chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113)
  fix: Long katex strings breaking overflow in x axis (#32609)
  fix: Force highlighted code language registration (#32507)
  fix: sidebar last message E2EE (#32431)
  chore: remove message column on moderation console (#32432)
  fix: Accepted Media Types settings validation (#32478)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants