Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove message column on moderation console #32432

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

csuadev
Copy link
Contributor

@csuadev csuadev commented May 14, 2024

This PR removes the message preview from the Moderation Console since it didn't wasn't useful for the admin and we need to lead them to click on the reports from a user to see all the messages from that specific user and check if any moderation is needed.

Proposed changes (including videos or screenshots)

Before:
image

After:
image

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-4

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 14, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 7.0.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 14, 2024

⚠️ No Changeset found

Latest commit: efda741

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.03%. Comparing base (2d84fe2) to head (fd9cb4f).
Report is 54 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32432      +/-   ##
===========================================
+ Coverage    55.60%   56.03%   +0.43%     
===========================================
  Files         2408     2456      +48     
  Lines        53023    54011     +988     
  Branches     10902    11120     +218     
===========================================
+ Hits         29483    30265     +782     
- Misses       20931    21086     +155     
- Partials      2609     2660      +51     
Flag Coverage Δ
e2e 56.04% <100.00%> (+0.93%) ⬆️
unit 72.04% <ø> (-0.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review May 16, 2024 08:54
@csuadev csuadev requested a review from a team as a code owner May 16, 2024 08:54
@csuadev csuadev added this to the 7.0 milestone May 20, 2024
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR fixes the problem, we need to change the PR title to fix: and add a changeset.

@csuadev csuadev changed the title chore: reported message text on quoted message chore: remove message text on moderation console Jun 6, 2024
@csuadev csuadev changed the title chore: remove message text on moderation console chore: remove message column on moderation console Jun 6, 2024
@csuadev csuadev requested a review from dougfabris June 6, 2024 10:49
Copy link
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to fix the indentation of the tests files?

Comment on lines 162 to 165
get btnOptionQuoteMessage(): Locator {
return this.page.getByRole('button', { name: 'Quote' });
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need this anymore...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants