Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2EE room setup header #32446

Open
wants to merge 59 commits into
base: develop
Choose a base branch
from
Open

feat: E2EE room setup header #32446

wants to merge 59 commits into from

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented May 16, 2024

This is a new Header for the E2EE room setup flow, idea is that we shouldn't show all the room actions on the setup window and only a few items makes sense to be kept on this Header.

This PR introduces a new E2EERoomHeaderToolbox which is a toolbox for this specific use-case which contains only 3 room actions, e2e, room-info and members tab.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

E2EE-27

Copy link
Contributor

dionisio-bot bot commented May 16, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: d14904c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/i18n Patch
@rocket.chat/meteor Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal changed the base branch from develop to e2e-unencrypted-setting May 16, 2024 11:30
Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 83.87097% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.88%. Comparing base (e00dbd0) to head (d14904c).
Report is 3 commits behind head on e2e-unencrypted-setting.

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                     @@
##           e2e-unencrypted-setting   #32446      +/-   ##
===========================================================
- Coverage                    55.95%   55.88%   -0.07%     
===========================================================
  Files                         2438     2421      -17     
  Lines                        53597    53328     -269     
  Branches                     11007    10953      -54     
===========================================================
- Hits                         29989    29804     -185     
+ Misses                       20972    20902      -70     
+ Partials                      2636     2622      -14     
Flag Coverage Δ
e2e 55.26% <83.87%> (-0.10%) ⬇️
unit 72.71% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review May 16, 2024 18:03
@yash-rajpal yash-rajpal requested a review from a team as a code owner May 16, 2024 18:03
hugocostadev
hugocostadev previously approved these changes May 20, 2024
@yash-rajpal yash-rajpal added this to the 6.9 milestone May 20, 2024
@scuciatto scuciatto removed this from the 6.9 milestone May 21, 2024
Base automatically changed from e2e-unencrypted-setting to develop May 24, 2024 20:08
@kodiakhq kodiakhq bot dismissed hugocostadev’s stale review May 24, 2024 20:08

The base branch was changed.

@kodiakhq kodiakhq bot requested a review from a team as a code owner May 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants