Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: E2EE room setup header #32446

Merged
merged 64 commits into from
Jun 17, 2024
Merged

feat: E2EE room setup header #32446

merged 64 commits into from
Jun 17, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented May 16, 2024

This is a new Header for the E2EE room setup flow, idea is that we shouldn't show all the room actions on the setup window and only a few items makes sense to be kept on this Header.

This PR introduces a new E2EERoomHeaderToolbox which is a toolbox for this specific use-case which contains only 3 room actions, e2e, room-info and members tab.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

E2EE-27

hugocostadev
hugocostadev previously approved these changes May 20, 2024
@yash-rajpal yash-rajpal added this to the 6.9 milestone May 20, 2024
@scuciatto scuciatto removed this from the 6.9 milestone May 21, 2024
Base automatically changed from e2e-unencrypted-setting to develop May 24, 2024 20:08
@kodiakhq kodiakhq bot dismissed hugocostadev’s stale review May 24, 2024 20:08

The base branch was changed.

@kodiakhq kodiakhq bot requested a review from a team as a code owner May 24, 2024 20:08
@yash-rajpal yash-rajpal removed the request for review from a team June 11, 2024 16:21
yash-rajpal and others added 2 commits June 12, 2024 23:33
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
@milton-rucks milton-rucks added this to the 6.10 milestone Jun 13, 2024
@milton-rucks milton-rucks added the stat: QA assured Means it has been tested and approved by a company insider label Jun 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 17, 2024
@kodiakhq kodiakhq bot merged commit 2ef71e8 into develop Jun 17, 2024
44 of 48 checks passed
@kodiakhq kodiakhq bot deleted the e2e-room-setup-header branch June 17, 2024 21:28
gabriellsh added a commit that referenced this pull request Jun 18, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat:
  fix: Not possible to edit room without proper permission with retention policy enabled (#32547)
  feat: Apps-Engine Deno Runtime update (#31821)
  feat: E2EE room setup header (#32446)
  fix: E2EE thread main message reactivity (#32381)
  chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113)
  fix: Long katex strings breaking overflow in x axis (#32609)
  fix: Force highlighted code language registration (#32507)
  fix: sidebar last message E2EE (#32431)
  chore: remove message column on moderation console (#32432)
  fix: Accepted Media Types settings validation (#32478)
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants