-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: E2EE room setup header #32446
base: develop
Are you sure you want to change the base?
feat: E2EE room setup header #32446
Conversation
…nd restoring commented test
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: d14904c The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## e2e-unencrypted-setting #32446 +/- ##
===========================================================
- Coverage 55.95% 55.88% -0.07%
===========================================================
Files 2438 2421 -17
Lines 53597 53328 -269
Branches 11007 10953 -54
===========================================================
- Hits 29989 29804 -185
+ Misses 20972 20902 -70
+ Partials 2636 2622 -14
Flags with carried forward coverage won't be shown. Click here to find out more. |
This is a new Header for the E2EE room setup flow, idea is that we shouldn't show all the room actions on the setup window and only a few items makes sense to be kept on this Header.
This PR introduces a new E2EERoomHeaderToolbox which is a toolbox for this specific use-case which contains only 3 room actions, e2e, room-info and members tab.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
E2EE-27