feat: Apps-Engine Deno Runtime update #31821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a01c3c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31821 +/- ##
===========================================
- Coverage 56.42% 55.70% -0.72%
===========================================
Files 2479 2416 -63
Lines 54581 53470 -1111
Branches 11269 11002 -267
===========================================
- Hits 30795 29785 -1010
+ Misses 21111 21058 -53
+ Partials 2675 2627 -48
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
force-pushed
the
feat/apps-deno-runtime
branch
from
d9accc0
to
f5656bb
Compare
* chore: use apps-engine with deno * fix: async operations * fix: async
* refactor: convert to typescript * feat: change storeEntries to receive logEntries instead appconsole instance * refactor: remove `logs-storage.js` * refactor: remove type `any` * fix: type errors * fix: implement correct method * chore: use apps engine with deno vm * Fix import --------- Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
* Improve readability for loading apps on startup * Fix slash command registration validation * Fix '/api/apps/installed' endpoint * fix: return correct logs information * Remove trycatch in http bridge as it was causing invalid responses * fix: return installed apps * Remove hardcoded url in http bridge * fix: use url with params * fix: slashcommand preview (#31814) --------- Co-authored-by: Douglas Gubert <douglas.gubert@gmail.com>
d-gubert
force-pushed
the
feat/apps-deno-runtime
branch
from
f5656bb
to
e7a23ca
Compare
d-gubert
commented
Jun 14, 2024
d-gubert
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
tapiarafael
reviewed
Jun 17, 2024
sampaiodiego
approved these changes
Jun 17, 2024
tapiarafael
approved these changes
Jun 17, 2024
gabriellsh
added a commit
that referenced
this pull request
Jun 18, 2024
…retention * 'develop' of github.com:RocketChat/Rocket.Chat: fix: Not possible to edit room without proper permission with retention policy enabled (#32547) feat: Apps-Engine Deno Runtime update (#31821) feat: E2EE room setup header (#32446) fix: E2EE thread main message reactivity (#32381) chore: Add telemetry to CI so we can get a better understanding of resource usage (#32113) fix: Long katex strings breaking overflow in x axis (#32609) fix: Force highlighted code language registration (#32507) fix: sidebar last message E2EE (#32431) chore: remove message column on moderation console (#32432) fix: Accepted Media Types settings validation (#32478)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR refactors the usage of the Apps-Engine so that it is compatible with the new Deno Runtime, as implemented in RocketChat/Rocket.Chat.Apps-engine#665
Issue(s)
PROJ-5
Steps to test or reproduce
Further comments